WebOS Internals - User contributions [en]

Patch Browser Downloading Files

2009-08-21T22:55:05Z

Dizzwave:

{{template:patch}}

'''NOTE -- This is newly 1.1 compatible'''

8/15/09 -1.1 Working Patch Up And Ready

Edit: Anything can be downloaded in this patch, but must download directly from the download link/url.

Must Be In '''[root@castle:/#]''' not '''[username@castle]''' to work !

<pre>
cd /opt/src/modifications
git pull

quilt import /opt/src/modifications/browser/enable-browser-downloads.patch

cd /
quilt push

reboot
</pre>

'''-All Done Patch Applied! NO NEED TO DO ANY PORTION AT BOTTOM'''

NOTE- Swipe to remove finished downloads widget at the bottom of the page, Must not be zoomed in to view

==================================================================================================================

As of 2009/07/06, all parts of this modification have been incorporated into the patch file at http://gitorious.org/webos-internals/modifications/blobs/raw/master/browser/enable-browser-downloads.patch.

If further modifications are made, but for whatever reason the patch cannot be updated according to the steps at [[Applying Patches]], please place these changes above the "PATCH" line so that someone else can incorporate them into the patch (and then note that they have been incorporated)

Also included is a change to DownloadDialogAssistant that clears out the onDismiss function when streaming. Otherwise, anytime you selected stream, the file would be downloaded as well (in the cleanup function).

It would be good if the developers contributing code could get gitorious accounts and keep this patch updated ...A

=Please add this code change to the patch file=
'''The phone number not launching the phone app issue has been fixed.'''
Open global_code.js, find the PageAssistant.prototype._streamResource function.
Under the Mojo.Log.error... line (at the top of the fn), add the following:
<pre><nowiki>
if(appid === 'com.palm.app.phone')
{
//a phone # was clicked, so we bypass the download dialog and open the phone app.
var params = {target: uri, mimeType: mimeType};
this.controller.serviceRequest('palm://com.palm.applicationManager',{
method: 'open',
parameters: {
'id': appid,
'params': params
}}
);
return;
}</nowiki></pre>

Right under there, the code continues on at this._downloadWidgetElement = .....

= PATCH=
'''CODE'''
The first step is to enable the required javascript sources through sources.json:

<pre><nowiki>
{
"source":"app\/models\/download-model.js"
},
{
"source":"app\/controllers\/download-request.js"
},
{
"source":"app\/controllers\/download-controller.js"
},
{
"source":"app\/controllers\/downloaddialog-assistant.js"
},
</nowiki></pre>

I put them directly before the import for global_code.js, as that is where they will be used from.

Next, at the end of the global_code.js function "PageAssistant.prototype.setup" (right before the ''} catch(e){...)'':

<pre><nowiki>
this._downloadController = new DownloadController(this.controller);
this._downloadController.setup();
</nowiki></pre>

'''SUCCESS''' - 6/24/2009
mdklein has fixed the infinite loop bug with browsers and unknown filetypes. It's a simple modification. Please let me know if this breaks anything...

'''I left the following out of the 1.1 patch update, since that part of the browser code has changed since 1.0, and we might not need it. (Works for mp3s, anyway... might need to be refactored yet.)'''
<s>
in page-assistant.js change the if statement "&& response.mimeByExtenstion" is added to verify we know it's a mime type. (yes, Palm typoed)
writing it this way in case they fix the typo in the future.
<pre><nowiki>
// Yes, palm, I caught your typo... writing it this way in case you fix it? function returns mimeByExtenstion... guessing it should be mimeByExtension
if (response.returnValue && response.canStream && (response.mimeByExtenstion||response.mimeByExtension)) {
this._streamResource(event.url, response.appIdByExtension, (response.mimeByExtenstion||response.mimeByExtenstion));
}

</nowiki></pre>
</s>

And then the downloadResource function, also in global_code.cs (note that we are now presenting a confirmation dialog). Replace the current function with this:
<pre><nowiki>
PageAssistant.prototype._downloadResource = function(uri) {

Mojo.Log.info("Downloading: " + uri);

try {
// We should no longer download a resource but inform the user
// we are unable to perform the download.
if (!this._downloadWidgetElement) {
this._downloadWidgetElement = this.controller.showDialog({
template: 'download/download-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function() {
//this._onPopupHandler('close');
delete this._downloadWidgetElement;
}.bind(this),
onAccept: function() {
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this)})
});

// Record we have a popup
//this._onPopupHandler('open');
}
} catch (e) {
Mojo.Log.logException(e, "#_downloadResource");
}

// Hide the address bar.
this._addressBar.hide();
this._webView.mojo.focus();
};
</nowiki></pre>
'''NOTE I commented out the lines that called _onPopupHandler, since there seems to be no such handler now in 1.1 (that I could find), and it didn't seem to matter.'''

Now we change the PageAssistant.prototype._streamResource function (also in global_code.js) to this:
<pre><nowiki>
PageAssistant.prototype._streamResource = function(uri, appid, mimeType){

Mojo.Log.error("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);

this._downloadWidgetElement = this.controller.showDialog({
uri: uri,
mimeType: mimeType,
appid: appid,
template: 'download/download-stream-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function(cParams) { // DOWNLOAD
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this),
onAccept: function(cParams) { // STREAM
var params = {target: uri, mimeType: mimeType, appid: appid};
// Only a few select applications can be
var crossAppScene = {
'com.palm.app.videoplayer': 'nowplaying',
'com.palm.app.streamingmusicplayer': 'nowplaying'
};
//this._onPopupHandler('close');
if (crossAppScene[appid]) {
var args = { appId: appid, name: crossAppScene[appid] };
this.controller.stageController.pushScene(args, params);
}
else {
this._downloadController.downloadResource(uri);
}
}.bind(this)})
});
// Record we have a popup
//this._onPopupHandler('open');

};
</nowiki></pre>
'''NOTE again that I commented out the _onPopupHandler calls.'''

Then we add a new file /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
<pre><nowiki>
/**
* A dialog assistant for display of yes/no box.
*/
DownloadDialogAssistant = Class.create({

initialize: function(params) {
this.onDismiss = params.onDismiss;
this.onAccept = params.onAccept;
this.controller= params.sceneAssistant.controller;

// Button handlers.
this.onDismissHandler = this.handleDismiss.bindAsEventListener(this);
this.onAcceptHandler = this.handleAccept.bindAsEventListener(this);
},

setup: function(widget) {
this.widget = widget;
this.controller.get('acceptButton').addEventListener(Mojo.Event.tap, this.onAcceptHandler);
this.controller.get('acceptButton').focus();
this.controller.get('dismissButton').addEventListener(Mojo.Event.tap, this.onDismissHandler);
this.controller.get('dismissButton').focus();
},

handleDismiss: function() {
this.onDismiss();
delete this.onDismiss;
this.widget.mojo.close();
},
handleAccept: function() {
this.onAccept();
delete this.onAccept;
this.widget.mojo.close();
},

cleanup: function() {
Mojo.Log.info("NetworkDialogAssistant#cleanup()");
Mojo.Event.stopListening(this.controller.get('dismissButton'), Mojo.Event.tap, this.onDismissHandler);
Mojo.Event.stopListening(this.controller.get('acceptButton'), Mojo.Event.tap, this.onAcceptHandler);

// Send a dismiss if NOT already sent a response
if (this.onDismiss) {
this.onDismiss();
}
}
});
</nowiki></pre>

'''RESOURCES'''
That is all the "code" that needs to be fixed. The rest would be considered resources.

you also need a /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc=""> Cannot find an application which can open this file. Would you like to download it to /media/internal/downloads?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Yes</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">No</div>
</div>
</nowiki></pre>

In app/views/page/page-scene.html, we append:

<pre><nowiki>
<div id="downloadListScroller" class="browser-download" x-mojo-element="Scroller">
<div id="downloadList" class="palm-list" x-mojo-element="List"></div>
</div>
</nowiki></pre>

and then in app/views/download/download-container.html, replace the contents with:
'''NOTE: the 1.0 version did not have a '-' before "listElements", but we need that hyphen there.'''
<pre><nowiki>
#{-listElements}
</nowiki></pre>

You will also need to create download-stream-popup.html in app/views/download:
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc="">This file type has been registered as a streaming media file. Would you like to download it to /media/internal/downloads instead?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Stream</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Download</div>
</div>
</nowiki></pre>

'''IMPORTANT NOTES:'''

The download widgets will be added to the bottom of the currently rendered page. If you are zoomed in, you probably won't be able to see them.

Swipe-to-delete works, but not the way you think. The widget will disappear, but the download will finish if it has not already, and will persist afterward. You will have to use a PC and mount the mass storage controller to remove downloads later.

'''SUCCESS''' - 6/23/2009
chris_phelps has completed a "Download" feature that creates it's own Scene for completed downloads in the browser.

[[Image:Dl-browser1.png]]
[[Image:Dl-browser2.png]]
[[Image:Dl-browser3.png]]

This however, was not the correct way to do things as the system is already keeping track of all downloads in it's own database. chris_phelps will be moving the code created specifically for the Download scene in the browser application into it's own application. Expect this by the end of the day maybe (6/24/2009) depending on how good the weather gets.

=====PATCH CODE=====
<pre>
Index: /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
===================================================================
--- /dev/null
+++ /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
@@ -0,0 +1,45 @@
+/**
+ * A dialog assistant for display of yes/no box.
+ */
+DownloadDialogAssistant = Class.create({
+
+ initialize: function(params) {
+ this.onDismiss = params.onDismiss;
+ this.onAccept = params.onAccept;
+ this.controller= params.sceneAssistant.controller;
+
+ // Button handlers.
+ this.onDismissHandler = this.handleDismiss.bindAsEventListener(this);
+ this.onAcceptHandler = this.handleAccept.bindAsEventListener(this);
+ },
+
+ setup: function(widget) {
+ this.widget = widget;
+ this.controller.get('acceptButton').addEventListener(Mojo.Event.tap, this.onAcceptHandler);
+ this.controller.get('acceptButton').focus();
+ this.controller.get('dismissButton').addEventListener(Mojo.Event.tap, this.onDismissHandler);
+ this.controller.get('dismissButton').focus();
+ },
+
+ handleDismiss: function() {
+ this.onDismiss();
+ delete this.onDismiss;
+ this.widget.mojo.close();
+ },
+ handleAccept: function() {
+ this.onAccept();
+ delete this.onAccept;
+ this.widget.mojo.close();
+ },
+
+ cleanup: function() {
+ Mojo.Log.info("NetworkDialogAssistant#cleanup()");
+ Mojo.Event.stopListening(this.controller.get('dismissButton'), Mojo.Event.tap, this.onDismissHandler);
+ Mojo.Event.stopListening(this.controller.get('acceptButton'), Mojo.Event.tap, this.onAcceptHandler);
+
+ // Send a dismiss if NOT already sent a response
+ if (this.onDismiss) {
+ this.onDismiss();
+ }
+ }
+});
Index: /usr/palm/applications/com.palm.app.browser/app/controllers/global_code.js
===================================================================
--- .orig/usr/palm/applications/com.palm.app.browser/app/controllers/global_code.js
+++ /usr/palm/applications/com.palm.app.browser/app/controllers/global_code.js
@@ -1449,6 +1449,8 @@ PageAssistant.prototype.setup = function
this._webView.addEventListener(Mojo.Event.webViewUrlRedirect, this._onUrlRedirect.bind(this), false);
this._webView.addEventListener(Mojo.Event.webViewModifierTap, this._onModifierTapHandler, false);
this._webView.addEventListener(Mojo.Event.webViewUpdateHistory, this._onUpdateHistoryHandler, false);
+ this._downloadController = new DownloadController(this.controller);
+ this._downloadController.setup();
}
catch (e) {
Mojo.Log.logException(e, 'PageAssistant#setup');
@@ -2287,28 +2289,39 @@ PageAssistant.prototype._newBrowserPage
*/
PageAssistant.prototype._streamResource = function(uri, appid, mimeType){

- Mojo.Log.info("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);
+ Mojo.Log.error("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);

- // Only a few select applications can be
- crossAppScene = {
- 'com.palm.app.videoplayer': 'nowplaying',
- 'com.palm.app.streamingmusicplayer': 'nowplaying'
- };
- var params = {target: uri, mimeType: mimeType};
- if (crossAppScene[appid]) {
+ this._downloadWidgetElement = this.controller.showDialog({
+ uri: uri,
+ mimeType: mimeType,
+ appid: appid,
+ template: 'download/download-stream-popup',
+ assistant: new DownloadDialogAssistant({
+ sceneAssistant: this,
+ onDismiss: function(cParams) { // DOWNLOAD
+ //this._onPopupHandler('close');
+ this._downloadController.downloadResource(uri);
+ }.bind(this),
+ onAccept: function(cParams) { // STREAM
+ var params = {target: uri, mimeType: mimeType, appid: appid};
+ // Only a few select applications can be
+ var crossAppScene = {
+ 'com.palm.app.videoplayer': 'nowplaying',
+ 'com.palm.app.streamingmusicplayer': 'nowplaying'
+ };
+ //this._onPopupHandler('close');
+ if (crossAppScene[appid]) {
+ var args = { appId: appid, name: crossAppScene[appid] };
+ this.controller.stageController.pushScene(args, params);
+ }
+ else {
+ this._downloadController.downloadResource(uri);
+ }
+ }.bind(this)})
+ });
+ // Record we have a popup
+ //this._onPopupHandler('open');

- var args = { appId: appid, name: crossAppScene[appid] };
- this.controller.stageController.pushScene(args, params);
- }
- else {
- this.controller.serviceRequest('palm://com.palm.applicationManager', {
- method: 'open',
- parameters: {
- 'id': appid,
- 'params': params
- }
- });
- }
};

/**
@@ -2318,16 +2331,29 @@ PageAssistant.prototype._streamResource
*/
PageAssistant.prototype._downloadResource = function(uri) {

- Mojo.Log.info("Downloading: " + uri);
+ Mojo.Log.info("Downloading: " + uri);

- try {
- // We should no longer download a resource but inform the user
- // we are unable to perform the download.
- this.controller.showAlertDialog({
- onChoose: function(value) { /* Do Nothing */},
- message: $L('Cannot find an application which can open this file.'),
- choices:[{label:$L('OK'), value:'1', type:'dismiss'}]
- });
+ try {
+ // We should no longer download a resource but inform the user
+ // we are unable to perform the download.
+ if (!this._downloadWidgetElement) {
+ this._downloadWidgetElement = this.controller.showDialog({
+ template: 'download/download-popup',
+ assistant: new DownloadDialogAssistant({
+ sceneAssistant: this,
+ onDismiss: function() {
+ //this._onPopupHandler('close');
+ delete this._downloadWidgetElement;
+ }.bind(this),
+ onAccept: function() {
+ //this._onPopupHandler('close');
+ this._downloadController.downloadResource(uri);
+ }.bind(this)})
+ });
+
+ // Record we have a popup
+ //this._onPopupHandler('open');
+ }
} catch (e) {
Mojo.Log.logException(e, "#_downloadResource");
}
Index: /usr/palm/applications/com.palm.app.browser/app/views/download/download-container.html
===================================================================
--- .orig/usr/palm/applications/com.palm.app.browser/app/views/download/download-container.html
+++ /usr/palm/applications/com.palm.app.browser/app/views/download/download-container.html
@@ -1,3 +1,3 @@
<div x-mojo-elements="List" class="palm-list no-lines">
- #{listElements}
+ #{-listElements}
</div>
\ No newline at end of file
Index: /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
===================================================================
--- /dev/null
+++ /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
@@ -0,0 +1,8 @@
+<div id="palm-dialog-content" class="palm-dialog-content">
+ <div class="dialog-message" x-mojo-loc=""> Cannot find an application which can open this file. Would you like to download it to /media/internal/downloads?</div>
+</div>
+
+<div class="palm-dialog-buttons">
+ <div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Yes</div>
+ <div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">No</div>
+</div>
Index: /usr/palm/applications/com.palm.app.browser/app/views/download/download-stream-popup.html
===================================================================
--- /dev/null
+++ /usr/palm/applications/com.palm.app.browser/app/views/download/download-stream-popup.html
@@ -0,0 +1,8 @@
+<div id="palm-dialog-content" class="palm-dialog-content">
+ <div class="dialog-message" x-mojo-loc="">This file type has been registered as a streaming media file. Would you like to download it to /media/internal/downloads instead?</div>
+</div>
+
+<div class="palm-dialog-buttons">
+ <div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Stream</div>
+ <div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Download</div>
+</div>
Index: /usr/palm/applications/com.palm.app.browser/app/views/page/page-scene.html
===================================================================
--- .orig/usr/palm/applications/com.palm.app.browser/app/views/page/page-scene.html
+++ /usr/palm/applications/com.palm.app.browser/app/views/page/page-scene.html
@@ -16,5 +16,9 @@
<div id="server-disconnected" class="palm-scrim">
<div id="server-disconnected-spinner" x-mojo-element="Spinner"></div>
</div>
+<div id="downloadListScroller" class="browser-download" x-mojo-element="Scroller">
+ <div id="downloadList" class="palm-list" x-mojo-element="List"></div>
+</div>
+

Index: /usr/palm/applications/com.palm.app.browser/sources.json
===================================================================
--- .orig/usr/palm/applications/com.palm.app.browser/sources.json
+++ /usr/palm/applications/com.palm.app.browser/sources.json
@@ -1,5 +1,17 @@
-[
+[
{
- "source": "app\/controllers\/global_code.js"
+ "source":"app\/models\/download-model.js"
+ },
+ {
+ "source":"app\/controllers\/download-request.js"
+ },
+ {
+ "source":"app\/controllers\/download-controller.js"
+ },
+ {
+ "source":"app\/controllers\/downloaddialog-assistant.js"
+ },
+ {
+ "source": "app\/controllers\/global_code.js"
}
]
</pre>

Patch Browser Downloading Files

2009-08-21T22:52:40Z

Dizzwave: fixed problem where clicking a phone # in a web page was not opening phone app.

{{template:patch}}

'''NOTE -- This is newly 1.1 compatible'''

8/15/09 -1.1 Working Patch Up And Ready

Edit: Anything can be downloaded in this patch, but must download directly from the download link/url.

Must Be In '''[root@castle:/#]''' not '''[username@castle]''' to work !

<pre>
cd /opt/src/modifications
git pull

quilt import /opt/src/modifications/browser/enable-browser-downloads.patch

cd /
quilt push

reboot
</pre>

'''-All Done Patch Applied! NO NEED TO DO ANY PORTION AT BOTTOM'''

NOTE- Swipe to remove finished downloads widget at the bottom of the page, Must not be zoomed in to view

==================================================================================================================

As of 2009/07/06, all parts of this modification have been incorporated into the patch file at http://gitorious.org/webos-internals/modifications/blobs/raw/master/browser/enable-browser-downloads.patch.

If further modifications are made, but for whatever reason the patch cannot be updated according to the steps at [[Applying Patches]], please place these changes above the "PATCH" line so that someone else can incorporate them into the patch (and then note that they have been incorporated)

Also included is a change to DownloadDialogAssistant that clears out the onDismiss function when streaming. Otherwise, anytime you selected stream, the file would be downloaded as well (in the cleanup function).

It would be good if the developers contributing code could get gitorious accounts and keep this patch updated ...A

=Please add this code change to the patch file=
'''The phone number not launching the phone app issue has been fixed.'''
Open global_code.js, find the PageAssistant.prototype._streamResource function.
Under the Mojo.Log.error... line (at the top of the fn), add the following:
<pre><nowiki>
if(appid === 'com.palm.app.phone')
{
//a phone # was clicked, so we bypass the download dialog and open the phone app.
var params = {target: uri, mimeType: mimeType};
this.controller.serviceRequest('palm://com.palm.applicationManager',{
method: 'open',
parameters: {
'id': appid,
'params': params
}}
);
return;
}</nowiki></pre>

= PATCH=
'''CODE'''
The first step is to enable the required javascript sources through sources.json:

<pre><nowiki>
{
"source":"app\/models\/download-model.js"
},
{
"source":"app\/controllers\/download-request.js"
},
{
"source":"app\/controllers\/download-controller.js"
},
{
"source":"app\/controllers\/downloaddialog-assistant.js"
},
</nowiki></pre>

I put them directly before the import for global_code.js, as that is where they will be used from.

Next, at the end of the global_code.js function "PageAssistant.prototype.setup" (right before the ''} catch(e){...)'':

<pre><nowiki>
this._downloadController = new DownloadController(this.controller);
this._downloadController.setup();
</nowiki></pre>

'''SUCCESS''' - 6/24/2009
mdklein has fixed the infinite loop bug with browsers and unknown filetypes. It's a simple modification. Please let me know if this breaks anything...

'''I left the following out of the 1.1 patch update, since that part of the browser code has changed since 1.0, and we might not need it. (Works for mp3s, anyway... might need to be refactored yet.)'''
<s>
in page-assistant.js change the if statement "&& response.mimeByExtenstion" is added to verify we know it's a mime type. (yes, Palm typoed)
writing it this way in case they fix the typo in the future.
<pre><nowiki>
// Yes, palm, I caught your typo... writing it this way in case you fix it? function returns mimeByExtenstion... guessing it should be mimeByExtension
if (response.returnValue && response.canStream && (response.mimeByExtenstion||response.mimeByExtension)) {
this._streamResource(event.url, response.appIdByExtension, (response.mimeByExtenstion||response.mimeByExtenstion));
}

</nowiki></pre>
</s>

And then the downloadResource function, also in global_code.cs (note that we are now presenting a confirmation dialog). Replace the current function with this:
<pre><nowiki>
PageAssistant.prototype._downloadResource = function(uri) {

Mojo.Log.info("Downloading: " + uri);

try {
// We should no longer download a resource but inform the user
// we are unable to perform the download.
if (!this._downloadWidgetElement) {
this._downloadWidgetElement = this.controller.showDialog({
template: 'download/download-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function() {
//this._onPopupHandler('close');
delete this._downloadWidgetElement;
}.bind(this),
onAccept: function() {
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this)})
});

// Record we have a popup
//this._onPopupHandler('open');
}
} catch (e) {
Mojo.Log.logException(e, "#_downloadResource");
}

// Hide the address bar.
this._addressBar.hide();
this._webView.mojo.focus();
};
</nowiki></pre>
'''NOTE I commented out the lines that called _onPopupHandler, since there seems to be no such handler now in 1.1 (that I could find), and it didn't seem to matter.'''

Now we change the PageAssistant.prototype._streamResource function (also in global_code.js) to this:
<pre><nowiki>
PageAssistant.prototype._streamResource = function(uri, appid, mimeType){

Mojo.Log.error("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);

this._downloadWidgetElement = this.controller.showDialog({
uri: uri,
mimeType: mimeType,
appid: appid,
template: 'download/download-stream-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function(cParams) { // DOWNLOAD
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this),
onAccept: function(cParams) { // STREAM
var params = {target: uri, mimeType: mimeType, appid: appid};
// Only a few select applications can be
var crossAppScene = {
'com.palm.app.videoplayer': 'nowplaying',
'com.palm.app.streamingmusicplayer': 'nowplaying'
};
//this._onPopupHandler('close');
if (crossAppScene[appid]) {
var args = { appId: appid, name: crossAppScene[appid] };
this.controller.stageController.pushScene(args, params);
}
else {
this._downloadController.downloadResource(uri);
}
}.bind(this)})
});
// Record we have a popup
//this._onPopupHandler('open');

};
</nowiki></pre>
'''NOTE again that I commented out the _onPopupHandler calls.'''

Then we add a new file /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
<pre><nowiki>
/**
* A dialog assistant for display of yes/no box.
*/
DownloadDialogAssistant = Class.create({

initialize: function(params) {
this.onDismiss = params.onDismiss;
this.onAccept = params.onAccept;
this.controller= params.sceneAssistant.controller;

// Button handlers.
this.onDismissHandler = this.handleDismiss.bindAsEventListener(this);
this.onAcceptHandler = this.handleAccept.bindAsEventListener(this);
},

setup: function(widget) {
this.widget = widget;
this.controller.get('acceptButton').addEventListener(Mojo.Event.tap, this.onAcceptHandler);
this.controller.get('acceptButton').focus();
this.controller.get('dismissButton').addEventListener(Mojo.Event.tap, this.onDismissHandler);
this.controller.get('dismissButton').focus();
},

handleDismiss: function() {
this.onDismiss();
delete this.onDismiss;
this.widget.mojo.close();
},
handleAccept: function() {
this.onAccept();
delete this.onAccept;
this.widget.mojo.close();
},

cleanup: function() {
Mojo.Log.info("NetworkDialogAssistant#cleanup()");
Mojo.Event.stopListening(this.controller.get('dismissButton'), Mojo.Event.tap, this.onDismissHandler);
Mojo.Event.stopListening(this.controller.get('acceptButton'), Mojo.Event.tap, this.onAcceptHandler);

// Send a dismiss if NOT already sent a response
if (this.onDismiss) {
this.onDismiss();
}
}
});
</nowiki></pre>

'''RESOURCES'''
That is all the "code" that needs to be fixed. The rest would be considered resources.

you also need a /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc=""> Cannot find an application which can open this file. Would you like to download it to /media/internal/downloads?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Yes</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">No</div>
</div>
</nowiki></pre>

In app/views/page/page-scene.html, we append:

<pre><nowiki>
<div id="downloadListScroller" class="browser-download" x-mojo-element="Scroller">
<div id="downloadList" class="palm-list" x-mojo-element="List"></div>
</div>
</nowiki></pre>

and then in app/views/download/download-container.html, replace the contents with:
'''NOTE: the 1.0 version did not have a '-' before "listElements", but we need that hyphen there.'''
<pre><nowiki>
#{-listElements}
</nowiki></pre>

You will also need to create download-stream-popup.html in app/views/download:
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc="">This file type has been registered as a streaming media file. Would you like to download it to /media/internal/downloads instead?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Stream</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Download</div>
</div>
</nowiki></pre>

'''IMPORTANT NOTES:'''

The download widgets will be added to the bottom of the currently rendered page. If you are zoomed in, you probably won't be able to see them.

Swipe-to-delete works, but not the way you think. The widget will disappear, but the download will finish if it has not already, and will persist afterward. You will have to use a PC and mount the mass storage controller to remove downloads later.

'''SUCCESS''' - 6/23/2009
chris_phelps has completed a "Download" feature that creates it's own Scene for completed downloads in the browser.

[[Image:Dl-browser1.png]]
[[Image:Dl-browser2.png]]
[[Image:Dl-browser3.png]]

This however, was not the correct way to do things as the system is already keeping track of all downloads in it's own database. chris_phelps will be moving the code created specifically for the Download scene in the browser application into it's own application. Expect this by the end of the day maybe (6/24/2009) depending on how good the weather gets.

=====PATCH CODE=====
<pre>
Index: /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
===================================================================
--- /dev/null
+++ /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
@@ -0,0 +1,45 @@
+/**
+ * A dialog assistant for display of yes/no box.
+ */
+DownloadDialogAssistant = Class.create({
+
+ initialize: function(params) {
+ this.onDismiss = params.onDismiss;
+ this.onAccept = params.onAccept;
+ this.controller= params.sceneAssistant.controller;
+
+ // Button handlers.
+ this.onDismissHandler = this.handleDismiss.bindAsEventListener(this);
+ this.onAcceptHandler = this.handleAccept.bindAsEventListener(this);
+ },
+
+ setup: function(widget) {
+ this.widget = widget;
+ this.controller.get('acceptButton').addEventListener(Mojo.Event.tap, this.onAcceptHandler);
+ this.controller.get('acceptButton').focus();
+ this.controller.get('dismissButton').addEventListener(Mojo.Event.tap, this.onDismissHandler);
+ this.controller.get('dismissButton').focus();
+ },
+
+ handleDismiss: function() {
+ this.onDismiss();
+ delete this.onDismiss;
+ this.widget.mojo.close();
+ },
+ handleAccept: function() {
+ this.onAccept();
+ delete this.onAccept;
+ this.widget.mojo.close();
+ },
+
+ cleanup: function() {
+ Mojo.Log.info("NetworkDialogAssistant#cleanup()");
+ Mojo.Event.stopListening(this.controller.get('dismissButton'), Mojo.Event.tap, this.onDismissHandler);
+ Mojo.Event.stopListening(this.controller.get('acceptButton'), Mojo.Event.tap, this.onAcceptHandler);
+
+ // Send a dismiss if NOT already sent a response
+ if (this.onDismiss) {
+ this.onDismiss();
+ }
+ }
+});
Index: /usr/palm/applications/com.palm.app.browser/app/controllers/global_code.js
===================================================================
--- .orig/usr/palm/applications/com.palm.app.browser/app/controllers/global_code.js
+++ /usr/palm/applications/com.palm.app.browser/app/controllers/global_code.js
@@ -1449,6 +1449,8 @@ PageAssistant.prototype.setup = function
this._webView.addEventListener(Mojo.Event.webViewUrlRedirect, this._onUrlRedirect.bind(this), false);
this._webView.addEventListener(Mojo.Event.webViewModifierTap, this._onModifierTapHandler, false);
this._webView.addEventListener(Mojo.Event.webViewUpdateHistory, this._onUpdateHistoryHandler, false);
+ this._downloadController = new DownloadController(this.controller);
+ this._downloadController.setup();
}
catch (e) {
Mojo.Log.logException(e, 'PageAssistant#setup');
@@ -2287,28 +2289,39 @@ PageAssistant.prototype._newBrowserPage
*/
PageAssistant.prototype._streamResource = function(uri, appid, mimeType){

- Mojo.Log.info("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);
+ Mojo.Log.error("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);

- // Only a few select applications can be
- crossAppScene = {
- 'com.palm.app.videoplayer': 'nowplaying',
- 'com.palm.app.streamingmusicplayer': 'nowplaying'
- };
- var params = {target: uri, mimeType: mimeType};
- if (crossAppScene[appid]) {
+ this._downloadWidgetElement = this.controller.showDialog({
+ uri: uri,
+ mimeType: mimeType,
+ appid: appid,
+ template: 'download/download-stream-popup',
+ assistant: new DownloadDialogAssistant({
+ sceneAssistant: this,
+ onDismiss: function(cParams) { // DOWNLOAD
+ //this._onPopupHandler('close');
+ this._downloadController.downloadResource(uri);
+ }.bind(this),
+ onAccept: function(cParams) { // STREAM
+ var params = {target: uri, mimeType: mimeType, appid: appid};
+ // Only a few select applications can be
+ var crossAppScene = {
+ 'com.palm.app.videoplayer': 'nowplaying',
+ 'com.palm.app.streamingmusicplayer': 'nowplaying'
+ };
+ //this._onPopupHandler('close');
+ if (crossAppScene[appid]) {
+ var args = { appId: appid, name: crossAppScene[appid] };
+ this.controller.stageController.pushScene(args, params);
+ }
+ else {
+ this._downloadController.downloadResource(uri);
+ }
+ }.bind(this)})
+ });
+ // Record we have a popup
+ //this._onPopupHandler('open');

- var args = { appId: appid, name: crossAppScene[appid] };
- this.controller.stageController.pushScene(args, params);
- }
- else {
- this.controller.serviceRequest('palm://com.palm.applicationManager', {
- method: 'open',
- parameters: {
- 'id': appid,
- 'params': params
- }
- });
- }
};

/**
@@ -2318,16 +2331,29 @@ PageAssistant.prototype._streamResource
*/
PageAssistant.prototype._downloadResource = function(uri) {

- Mojo.Log.info("Downloading: " + uri);
+ Mojo.Log.info("Downloading: " + uri);

- try {
- // We should no longer download a resource but inform the user
- // we are unable to perform the download.
- this.controller.showAlertDialog({
- onChoose: function(value) { /* Do Nothing */},
- message: $L('Cannot find an application which can open this file.'),
- choices:[{label:$L('OK'), value:'1', type:'dismiss'}]
- });
+ try {
+ // We should no longer download a resource but inform the user
+ // we are unable to perform the download.
+ if (!this._downloadWidgetElement) {
+ this._downloadWidgetElement = this.controller.showDialog({
+ template: 'download/download-popup',
+ assistant: new DownloadDialogAssistant({
+ sceneAssistant: this,
+ onDismiss: function() {
+ //this._onPopupHandler('close');
+ delete this._downloadWidgetElement;
+ }.bind(this),
+ onAccept: function() {
+ //this._onPopupHandler('close');
+ this._downloadController.downloadResource(uri);
+ }.bind(this)})
+ });
+
+ // Record we have a popup
+ //this._onPopupHandler('open');
+ }
} catch (e) {
Mojo.Log.logException(e, "#_downloadResource");
}
Index: /usr/palm/applications/com.palm.app.browser/app/views/download/download-container.html
===================================================================
--- .orig/usr/palm/applications/com.palm.app.browser/app/views/download/download-container.html
+++ /usr/palm/applications/com.palm.app.browser/app/views/download/download-container.html
@@ -1,3 +1,3 @@
<div x-mojo-elements="List" class="palm-list no-lines">
- #{listElements}
+ #{-listElements}
</div>
\ No newline at end of file
Index: /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
===================================================================
--- /dev/null
+++ /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
@@ -0,0 +1,8 @@
+<div id="palm-dialog-content" class="palm-dialog-content">
+ <div class="dialog-message" x-mojo-loc=""> Cannot find an application which can open this file. Would you like to download it to /media/internal/downloads?</div>
+</div>
+
+<div class="palm-dialog-buttons">
+ <div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Yes</div>
+ <div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">No</div>
+</div>
Index: /usr/palm/applications/com.palm.app.browser/app/views/download/download-stream-popup.html
===================================================================
--- /dev/null
+++ /usr/palm/applications/com.palm.app.browser/app/views/download/download-stream-popup.html
@@ -0,0 +1,8 @@
+<div id="palm-dialog-content" class="palm-dialog-content">
+ <div class="dialog-message" x-mojo-loc="">This file type has been registered as a streaming media file. Would you like to download it to /media/internal/downloads instead?</div>
+</div>
+
+<div class="palm-dialog-buttons">
+ <div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Stream</div>
+ <div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Download</div>
+</div>
Index: /usr/palm/applications/com.palm.app.browser/app/views/page/page-scene.html
===================================================================
--- .orig/usr/palm/applications/com.palm.app.browser/app/views/page/page-scene.html
+++ /usr/palm/applications/com.palm.app.browser/app/views/page/page-scene.html
@@ -16,5 +16,9 @@
<div id="server-disconnected" class="palm-scrim">
<div id="server-disconnected-spinner" x-mojo-element="Spinner"></div>
</div>
+<div id="downloadListScroller" class="browser-download" x-mojo-element="Scroller">
+ <div id="downloadList" class="palm-list" x-mojo-element="List"></div>
+</div>
+

Index: /usr/palm/applications/com.palm.app.browser/sources.json
===================================================================
--- .orig/usr/palm/applications/com.palm.app.browser/sources.json
+++ /usr/palm/applications/com.palm.app.browser/sources.json
@@ -1,5 +1,17 @@
-[
+[
{
- "source": "app\/controllers\/global_code.js"
+ "source":"app\/models\/download-model.js"
+ },
+ {
+ "source":"app\/controllers\/download-request.js"
+ },
+ {
+ "source":"app\/controllers\/download-controller.js"
+ },
+ {
+ "source":"app\/controllers\/downloaddialog-assistant.js"
+ },
+ {
+ "source": "app\/controllers\/global_code.js"
}
]
</pre>

Patch Browser Downloading Files

2009-08-15T06:34:12Z

Dizzwave: cleanup

{{template:patch}}

'''NOTE -- This is newly 1.1 compatible'''

'''-1.1 Working Patch Up And Ready http://filebin.ca/xfjjme/enable-browser-downloads110.patch'''

'''Patch still needs to be uploaded to gitorious to replace the 1.0 patch below:'''

As of 2009/07/06, all parts of this modification have been incorporated into the patch file at http://gitorious.org/webos-internals/modifications/blobs/raw/master/browser/enable-browser-downloads.patch.

If further modifications are made, but for whatever reason the patch cannot be updated according to the steps at [[Applying Patches]], please place these changes above the "PATCH" line so that someone else can incorporate them into the patch (and then note that they have been incorporated)

Also included is a change to DownloadDialogAssistant that clears out the onDismiss function when streaming. Otherwise, anytime you selected stream, the file would be downloaded as well (in the cleanup function).

It would be good if the developers contributing code could get gitorious accounts and keep this patch updated ...A

= PATCH=
'''CODE'''
The first step is to enable the required javascript sources through sources.json:

<pre><nowiki>
{
"source":"app\/models\/download-model.js"
},
{
"source":"app\/controllers\/download-request.js"
},
{
"source":"app\/controllers\/download-controller.js"
},
{
"source":"app\/controllers\/downloaddialog-assistant.js"
},
</nowiki></pre>

I put them directly before the import for global_code.js, as that is where they will be used from.

Next, at the end of the global_code.js function "PageAssistant.prototype.setup" (right before the ''} catch(e){...)'':

<pre><nowiki>
this._downloadController = new DownloadController(this.controller);
this._downloadController.setup();
</nowiki></pre>

'''SUCCESS''' - 6/24/2009
mdklein has fixed the infinite loop bug with browsers and unknown filetypes. It's a simple modification. Please let me know if this breaks anything...

'''I left the following out of the 1.1 patch update, since that part of the browser code has changed since 1.0, and we might not need it. (Works for mp3s, anyway... might need to be refactored yet.)'''
<s>
in page-assistant.js change the if statement "&& response.mimeByExtenstion" is added to verify we know it's a mime type. (yes, Palm typoed)
writing it this way in case they fix the typo in the future.
<pre><nowiki>
// Yes, palm, I caught your typo... writing it this way in case you fix it? function returns mimeByExtenstion... guessing it should be mimeByExtension
if (response.returnValue && response.canStream && (response.mimeByExtenstion||response.mimeByExtension)) {
this._streamResource(event.url, response.appIdByExtension, (response.mimeByExtenstion||response.mimeByExtenstion));
}

</nowiki></pre>
</s>

And then the downloadResource function, also in global_code.cs (note that we are now presenting a confirmation dialog). Replace the current function with this:
<pre><nowiki>
PageAssistant.prototype._downloadResource = function(uri) {

Mojo.Log.info("Downloading: " + uri);

try {
// We should no longer download a resource but inform the user
// we are unable to perform the download.
if (!this._downloadWidgetElement) {
this._downloadWidgetElement = this.controller.showDialog({
template: 'download/download-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function() {
//this._onPopupHandler('close');
delete this._downloadWidgetElement;
}.bind(this),
onAccept: function() {
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this)})
});

// Record we have a popup
//this._onPopupHandler('open');
}
} catch (e) {
Mojo.Log.logException(e, "#_downloadResource");
}

// Hide the address bar.
this._addressBar.hide();
this._webView.mojo.focus();
};
</nowiki></pre>
'''NOTE I commented out the lines that called _onPopupHandler, since there seems to be no such handler now in 1.1 (that I could find), and it didn't seem to matter.'''

Now we change the PageAssistant.prototype._streamResource function (also in global_code.js) to this:
<pre><nowiki>
PageAssistant.prototype._streamResource = function(uri, appid, mimeType){

Mojo.Log.error("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);

this._downloadWidgetElement = this.controller.showDialog({
uri: uri,
mimeType: mimeType,
appid: appid,
template: 'download/download-stream-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function(cParams) { // DOWNLOAD
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this),
onAccept: function(cParams) { // STREAM
var params = {target: uri, mimeType: mimeType, appid: appid};
// Only a few select applications can be
var crossAppScene = {
'com.palm.app.videoplayer': 'nowplaying',
'com.palm.app.streamingmusicplayer': 'nowplaying'
};
//this._onPopupHandler('close');
if (crossAppScene[appid]) {
var args = { appId: appid, name: crossAppScene[appid] };
this.controller.stageController.pushScene(args, params);
}
else {
this._downloadController.downloadResource(uri);
}
}.bind(this)})
});
// Record we have a popup
//this._onPopupHandler('open');

};
</nowiki></pre>
'''NOTE again that I commented out the _onPopupHandler calls.'''

Then we add a new file /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
<pre><nowiki>
/**
* A dialog assistant for display of yes/no box.
*/
DownloadDialogAssistant = Class.create({

initialize: function(params) {
this.onDismiss = params.onDismiss;
this.onAccept = params.onAccept;
this.controller= params.sceneAssistant.controller;

// Button handlers.
this.onDismissHandler = this.handleDismiss.bindAsEventListener(this);
this.onAcceptHandler = this.handleAccept.bindAsEventListener(this);
},

setup: function(widget) {
this.widget = widget;
this.controller.get('acceptButton').addEventListener(Mojo.Event.tap, this.onAcceptHandler);
this.controller.get('acceptButton').focus();
this.controller.get('dismissButton').addEventListener(Mojo.Event.tap, this.onDismissHandler);
this.controller.get('dismissButton').focus();
},

handleDismiss: function() {
this.onDismiss();
delete this.onDismiss;
this.widget.mojo.close();
},
handleAccept: function() {
this.onAccept();
delete this.onAccept;
this.widget.mojo.close();
},

cleanup: function() {
Mojo.Log.info("NetworkDialogAssistant#cleanup()");
Mojo.Event.stopListening(this.controller.get('dismissButton'), Mojo.Event.tap, this.onDismissHandler);
Mojo.Event.stopListening(this.controller.get('acceptButton'), Mojo.Event.tap, this.onAcceptHandler);

// Send a dismiss if NOT already sent a response
if (this.onDismiss) {
this.onDismiss();
}
}
});
</nowiki></pre>

'''RESOURCES'''
That is all the "code" that needs to be fixed. The rest would be considered resources.

you also need a /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc=""> Cannot find an application which can open this file. Would you like to download it to /media/internal/downloads?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Yes</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">No</div>
</div>
</nowiki></pre>

In app/views/page/page-scene.html, we append:

<pre><nowiki>
<div id="downloadListScroller" class="browser-download" x-mojo-element="Scroller">
<div id="downloadList" class="palm-list" x-mojo-element="List"></div>
</div>
</nowiki></pre>

and then in app/views/download/download-container.html, replace the contents with:
'''NOTE: the 1.0 version did not have a '-' before "listElements", but we need that hyphen there.'''
<pre><nowiki>
#{-listElements}
</nowiki></pre>

You will also need to create download-stream-popup.html in app/views/download:
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc="">This file type has been registered as a streaming media file. Would you like to download it to /media/internal/downloads instead?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Stream</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Download</div>
</div>
</nowiki></pre>

'''IMPORTANT NOTES:'''

The download widgets will be added to the bottom of the currently rendered page. If you are zoomed in, you probably won't be able to see them.

Swipe-to-delete works, but not the way you think. The widget will disappear, but the download will finish if it has not already, and will persist afterward. You will have to use a PC and mount the mass storage controller to remove downloads later.

'''SUCCESS''' - 6/23/2009
chris_phelps has completed a "Download" feature that creates it's own Scene for completed downloads in the browser.

[[Image:Dl-browser1.png]]
[[Image:Dl-browser2.png]]
[[Image:Dl-browser3.png]]

This however, was not the correct way to do things as the system is already keeping track of all downloads in it's own database. chris_phelps will be moving the code created specifically for the Download scene in the browser application into it's own application. Expect this by the end of the day maybe (6/24/2009) depending on how good the weather gets.

Patch Browser Downloading Files

2009-08-13T05:17:40Z

Dizzwave: reply to note

{{template:patch}}

'''NOTE -- This is newly 1.1 compatible, but the Patch file linked below has not been updated. Anybody wanna do that for me?'''

'''ANOTHER NOTE -- I haven't extensively tested the 1.1 version of the changes. I've confirmed that it works for mp3s, but not other filetypes yet.'''

As of 2009/07/06, all parts of this modification have been incorporated into the patch file at http://gitorious.org/webos-internals/modifications/blobs/raw/master/browser/enable-browser-downloads.patch.

If further modifications are made, but for whatever reason the patch cannot be updated according to the steps at [[Applying Patches]], please place these changes above the "PATCH" line so that someone else can incorporate them into the patch (and then note that they have been incorporated)

'''NOTE''' from dizzwave -- sorry I didn't follow this rule, but since so much stuff got moved around, I didn't see the point of moving everything above the PATCH line. I hope that's ok.

This patch file contains all of the modifications described below the PATCH line, as well as a typo correction (believe it or not, mimeByExtenstion '''IS''' correct, see the following output if you don't believe it):

<pre><nowiki>
luna-send -n 1 palm://com.palm.applicationManager/getResourceInfo '{"uri":"http://www.podtrac.com/pts/redirect.mp3/aolradio.podcast.aol.com/twit/TWiT0202H.mp3"}'
</nowiki></pre>
'''NOTE''' They seem to have fixed that typo in 1.1. :)

Also included is a change to DownloadDialogAssistant that clears out the onDismiss function when streaming. Otherwise, anytime you selected stream, the file would be downloaded as well (in the cleanup function).

It would be good if the developers contributing code could get gitorious accounts and keep this patch updated ...A

Note: WOW! I used this a lot before and can't wait to use it post-1.1. How do I apply it from Quilt? I don't see it listed there.

Reply: Yep, i haven't updated the patch yet, just the code changing instructions. I'll try to get on that! -dizz
= PATCH=

NOTE: 6/24/2009
chris_phelps merged all of the sections from mdklein back into one set of directions. If you have already done the first part, you will have to figure out what is left for yourself.

NOTE: 8/11/2009 (dizzwave) Making some minor changes to the code below so as to work with 1.1. My changes in '''bold''', with the old stuff <s>struckthrough</s>, for clarity (and to help whoever fixes up the patch file!:)).

During some of my initial digging in the Browser application, I discovered that Palm developers had left quite a bit of code in place to enable downloading via the web interface. User mdklein was interested in the same fix at the same time (6/22/2009), so we shared information as we moved forward.

'''CODE'''
The first step is to enable the required javascript sources through sources.json:

<pre><nowiki>
{
"source":"app\/models\/download-model.js"
},
{
"source":"app\/controllers\/download-request.js"
},
{
"source":"app\/controllers\/download-controller.js"
},
{
"source":"app\/controllers\/downloaddialog-assistant.js"
},
</nowiki></pre>

I put them directly before the import for <s>page-assistant.js</s>'''global_code.js''', as that is where they will be used from.

Next, at the end of the <s>app/controllers/page-assistant.js</s>'''global_code.js''' function "PageAssistant.prototype.setup" (right before the ''} catch(e){...)'':

<pre><nowiki>
this._downloadController = new DownloadController(this.controller);
this._downloadController.setup();
</nowiki></pre>

'''SUCCESS''' - 6/24/2009
mdklein has fixed the infinite loop bug with browsers and unknown filetypes. It's a simple modification. Please let me know if this breaks anything...

'''I left this out for now, since that part of the browser code has changed since 1.0, and we might not need it. (Works for mp3s, anyway... might need to be refactored yet.)'''
<s>
in page-assistant.js change the if statement "&& response.mimeByExtenstion" is added to verify we know it's a mime type. (yes, Palm typoed)
writing it this way in case they fix the typo in the future.
<pre><nowiki>
// Yes, palm, I caught your typo... writing it this way in case you fix it? function returns mimeByExtenstion... guessing it should be mimeByExtension
if (response.returnValue && response.canStream && (response.mimeByExtenstion||response.mimeByExtension)) {
this._streamResource(event.url, response.appIdByExtension, (response.mimeByExtenstion||response.mimeByExtenstion));
}

</nowiki></pre>
</s>

And then the downloadResource function, '''also in global_code.cs''' (note that we are now presenting a confirmation dialog). Replace the current function with this:
<pre><nowiki>
PageAssistant.prototype._downloadResource = function(uri) {

Mojo.Log.info("Downloading: " + uri);

try {
// We should no longer download a resource but inform the user
// we are unable to perform the download.
if (!this._downloadWidgetElement) {
this._downloadWidgetElement = this.controller.showDialog({
template: 'download/download-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function() {
//this._onPopupHandler('close');
delete this._downloadWidgetElement;
}.bind(this),
onAccept: function() {
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this)})
});

// Record we have a popup
//this._onPopupHandler('open');
}
} catch (e) {
Mojo.Log.logException(e, "#_downloadResource");
}

// Hide the address bar.
this._addressBar.hide();
this._webView.mojo.focus();
};
</nowiki></pre>
'''NOTE I commented out the lines that called _onPopupHandler, since there seems to be no such handler now (that I could find), and it didn't seem to matter.'''

Now we change the PageAssistant.prototype._streamResource function ('''also in global_code.js''') to this:
<pre><nowiki>
PageAssistant.prototype._streamResource = function(uri, appid, mimeType){

Mojo.Log.error("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);

this._downloadWidgetElement = this.controller.showDialog({
uri: uri,
mimeType: mimeType,
appid: appid,
template: 'download/download-stream-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function(cParams) { // DOWNLOAD
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this),
onAccept: function(cParams) { // STREAM
var params = {target: uri, mimeType: mimeType, appid: appid};
// Only a few select applications can be
var crossAppScene = {
'com.palm.app.videoplayer': 'nowplaying',
'com.palm.app.streamingmusicplayer': 'nowplaying'
};
//this._onPopupHandler('close');
if (crossAppScene[appid]) {
var args = { appId: appid, name: crossAppScene[appid] };
this.controller.stageController.pushScene(args, params);
}
else {
this._downloadController.downloadResource(uri);
}
}.bind(this)})
});
// Record we have a popup
//this._onPopupHandler('open');

};
</nowiki></pre>
'''NOTE again that I commented out the _onPopupHandler calls.'''

Then we add a new file /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
<pre><nowiki>
/**
* A dialog assistant for display of yes/no box.
*/
DownloadDialogAssistant = Class.create({

initialize: function(params) {
this.onDismiss = params.onDismiss;
this.onAccept = params.onAccept;
this.controller= params.sceneAssistant.controller;

// Button handlers.
this.onDismissHandler = this.handleDismiss.bindAsEventListener(this);
this.onAcceptHandler = this.handleAccept.bindAsEventListener(this);
},

setup: function(widget) {
this.widget = widget;
this.controller.get('acceptButton').addEventListener(Mojo.Event.tap, this.onAcceptHandler);
this.controller.get('acceptButton').focus();
this.controller.get('dismissButton').addEventListener(Mojo.Event.tap, this.onDismissHandler);
this.controller.get('dismissButton').focus();
},

handleDismiss: function() {
this.onDismiss();
delete this.onDismiss;
this.widget.mojo.close();
},
handleAccept: function() {
this.onAccept();
delete this.onAccept;
this.widget.mojo.close();
},

cleanup: function() {
Mojo.Log.info("NetworkDialogAssistant#cleanup()");
Mojo.Event.stopListening(this.controller.get('dismissButton'), Mojo.Event.tap, this.onDismissHandler);
Mojo.Event.stopListening(this.controller.get('acceptButton'), Mojo.Event.tap, this.onAcceptHandler);

// Send a dismiss if NOT already sent a response
if (this.onDismiss) {
this.onDismiss();
}
}
});
</nowiki></pre>

'''RESOURCES'''
That is all the "code" that needs to be fixed. The rest would be considered resources.

you also need a /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc=""> Cannot find an application which can open this file. Would you like to download it to /media/internal/downloads?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Yes</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">No</div>
</div>
</nowiki></pre>

In app/views/page/page-scene.html, we append:

<pre><nowiki>
<div id="downloadListScroller" class="browser-download" x-mojo-element="Scroller">
<div id="downloadList" class="palm-list" x-mojo-element="List"></div>
</div>
</nowiki></pre>

and then in app/views/download/download-container.html, replace the contents with:
'''NOTE: the 1.0 version did not have a '-' before "listElements", but we need that hyphen there.'''
<pre><nowiki>
#{-listElements}
</nowiki></pre>

You will also need to create download-stream-popup.html in app/views/download:
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc="">This file type has been registered as a streaming media file. Would you like to download it to /media/internal/downloads instead?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Stream</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Download</div>
</div>
</nowiki></pre>

'''IMPORTANT NOTES:'''

The download widgets will be added to the bottom of the currently rendered page. If you are zoomed in, you probably won't be able to see them.

Swipe-to-delete works, but not the way you think. The widget will disappear, but the download will finish if it has not already, and will persist afterward. You will have to use a PC and mount the mass storage controller to remove downloads later.

'''SUCCESS''' - 6/23/2009
chris_phelps has completed a "Download" feature that creates it's own Scene for completed downloads in the browser.

[[Image:Dl-browser1.png]]
[[Image:Dl-browser2.png]]
[[Image:Dl-browser3.png]]

This however, was not the correct way to do things as the system is already keeping track of all downloads in it's own database. chris_phelps will be moving the code created specifically for the Download scene in the browser application into it's own application. Expect this by the end of the day maybe (6/24/2009) depending on how good the weather gets.

Patch Browser Downloading Files

2009-08-11T21:05:30Z

Dizzwave:

{{template:patch}}

'''NOTE -- This is newly 1.1 compatible, but the Patch file linked below has not been updated. Anybody wanna do that for me?'''

'''ANOTHER NOTE -- I haven't extensively tested the 1.1 version of the changes. I've confirmed that it works for mp3s, but not other filetypes yet.'''

As of 2009/07/06, all parts of this modification have been incorporated into the patch file at http://gitorious.org/webos-internals/modifications/blobs/raw/master/browser/enable-browser-downloads.patch.

If further modifications are made, but for whatever reason the patch cannot be updated according to the steps at [[Applying Patches]], please place these changes above the "PATCH" line so that someone else can incorporate them into the patch (and then note that they have been incorporated)

'''NOTE''' from dizzwave -- sorry I didn't follow this rule, but since so much stuff got moved around, I didn't see the point of moving everything above the PATCH line. I hope that's ok.

This patch file contains all of the modifications described below the PATCH line, as well as a typo correction (believe it or not, mimeByExtenstion '''IS''' correct, see the following output if you don't believe it):

<pre><nowiki>
luna-send -n 1 palm://com.palm.applicationManager/getResourceInfo '{"uri":"http://www.podtrac.com/pts/redirect.mp3/aolradio.podcast.aol.com/twit/TWiT0202H.mp3"}'
</nowiki></pre>
'''NOTE''' They seem to have fixed that typo in 1.1. :)

Also included is a change to DownloadDialogAssistant that clears out the onDismiss function when streaming. Otherwise, anytime you selected stream, the file would be downloaded as well (in the cleanup function).

It would be good if the developers contributing code could get gitorious accounts and keep this patch updated ...A

= PATCH=

NOTE: 6/24/2009
chris_phelps merged all of the sections from mdklein back into one set of directions. If you have already done the first part, you will have to figure out what is left for yourself.

NOTE: 8/11/2009 (dizzwave) Making some minor changes to the code below so as to work with 1.1. My changes in '''bold''', with the old stuff <s>struckthrough</s>, for clarity (and to help whoever fixes up the patch file!:)).

During some of my initial digging in the Browser application, I discovered that Palm developers had left quite a bit of code in place to enable downloading via the web interface. User mdklein was interested in the same fix at the same time (6/22/2009), so we shared information as we moved forward.

'''CODE'''
The first step is to enable the required javascript sources through sources.json:

<pre><nowiki>
{
"source":"app\/models\/download-model.js"
},
{
"source":"app\/controllers\/download-request.js"
},
{
"source":"app\/controllers\/download-controller.js"
},
{
"source":"app\/controllers\/downloaddialog-assistant.js"
},
</nowiki></pre>

I put them directly before the import for <s>page-assistant.js</s>'''global_code.js''', as that is where they will be used from.

Next, at the end of the <s>app/controllers/page-assistant.js</s>'''global_code.js''' function "PageAssistant.prototype.setup" (right before the ''} catch(e){...)'':

<pre><nowiki>
this._downloadController = new DownloadController(this.controller);
this._downloadController.setup();
</nowiki></pre>

'''SUCCESS''' - 6/24/2009
mdklein has fixed the infinite loop bug with browsers and unknown filetypes. It's a simple modification. Please let me know if this breaks anything...

'''I left this out for now, since that part of the browser code has changed since 1.0, and we might not need it. (Works for mp3s, anyway... might need to be refactored yet.)'''
<s>
in page-assistant.js change the if statement "&& response.mimeByExtenstion" is added to verify we know it's a mime type. (yes, Palm typoed)
writing it this way in case they fix the typo in the future.
<pre><nowiki>
// Yes, palm, I caught your typo... writing it this way in case you fix it? function returns mimeByExtenstion... guessing it should be mimeByExtension
if (response.returnValue && response.canStream && (response.mimeByExtenstion||response.mimeByExtension)) {
this._streamResource(event.url, response.appIdByExtension, (response.mimeByExtenstion||response.mimeByExtenstion));
}

</nowiki></pre>
</s>

And then the downloadResource function, '''also in global_code.cs''' (note that we are now presenting a confirmation dialog). Replace the current function with this:
<pre><nowiki>
PageAssistant.prototype._downloadResource = function(uri) {

Mojo.Log.info("Downloading: " + uri);

try {
// We should no longer download a resource but inform the user
// we are unable to perform the download.
if (!this._downloadWidgetElement) {
this._downloadWidgetElement = this.controller.showDialog({
template: 'download/download-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function() {
//this._onPopupHandler('close');
delete this._downloadWidgetElement;
}.bind(this),
onAccept: function() {
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this)})
});

// Record we have a popup
//this._onPopupHandler('open');
}
} catch (e) {
Mojo.Log.logException(e, "#_downloadResource");
}

// Hide the address bar.
this._addressBar.hide();
this._webView.mojo.focus();
};
</nowiki></pre>
'''NOTE I commented out the lines that called _onPopupHandler, since there seems to be no such handler now (that I could find), and it didn't seem to matter.'''

Now we change the PageAssistant.prototype._streamResource function ('''also in global_code.js''') to this:
<pre><nowiki>
PageAssistant.prototype._streamResource = function(uri, appid, mimeType){

Mojo.Log.error("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);

this._downloadWidgetElement = this.controller.showDialog({
uri: uri,
mimeType: mimeType,
appid: appid,
template: 'download/download-stream-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function(cParams) { // DOWNLOAD
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this),
onAccept: function(cParams) { // STREAM
var params = {target: uri, mimeType: mimeType, appid: appid};
// Only a few select applications can be
var crossAppScene = {
'com.palm.app.videoplayer': 'nowplaying',
'com.palm.app.streamingmusicplayer': 'nowplaying'
};
//this._onPopupHandler('close');
if (crossAppScene[appid]) {
var args = { appId: appid, name: crossAppScene[appid] };
this.controller.stageController.pushScene(args, params);
}
else {
this._downloadController.downloadResource(uri);
}
}.bind(this)})
});
// Record we have a popup
//this._onPopupHandler('open');

};
</nowiki></pre>
'''NOTE again that I commented out the _onPopupHandler calls.'''

Then we add a new file /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
<pre><nowiki>
/**
* A dialog assistant for display of yes/no box.
*/
DownloadDialogAssistant = Class.create({

initialize: function(params) {
this.onDismiss = params.onDismiss;
this.onAccept = params.onAccept;
this.controller= params.sceneAssistant.controller;

// Button handlers.
this.onDismissHandler = this.handleDismiss.bindAsEventListener(this);
this.onAcceptHandler = this.handleAccept.bindAsEventListener(this);
},

setup: function(widget) {
this.widget = widget;
this.controller.get('acceptButton').addEventListener(Mojo.Event.tap, this.onAcceptHandler);
this.controller.get('acceptButton').focus();
this.controller.get('dismissButton').addEventListener(Mojo.Event.tap, this.onDismissHandler);
this.controller.get('dismissButton').focus();
},

handleDismiss: function() {
this.onDismiss();
delete this.onDismiss;
this.widget.mojo.close();
},
handleAccept: function() {
this.onAccept();
delete this.onAccept;
this.widget.mojo.close();
},

cleanup: function() {
Mojo.Log.info("NetworkDialogAssistant#cleanup()");
Mojo.Event.stopListening(this.controller.get('dismissButton'), Mojo.Event.tap, this.onDismissHandler);
Mojo.Event.stopListening(this.controller.get('acceptButton'), Mojo.Event.tap, this.onAcceptHandler);

// Send a dismiss if NOT already sent a response
if (this.onDismiss) {
this.onDismiss();
}
}
});
</nowiki></pre>

'''RESOURCES'''
That is all the "code" that needs to be fixed. The rest would be considered resources.

you also need a /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc=""> Cannot find an application which can open this file. Would you like to download it to /media/internal/downloads?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Yes</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">No</div>
</div>
</nowiki></pre>

In app/views/page/page-scene.html, we append:

<pre><nowiki>
<div id="downloadListScroller" class="browser-download" x-mojo-element="Scroller">
<div id="downloadList" class="palm-list" x-mojo-element="List"></div>
</div>
</nowiki></pre>

and then in app/views/download/download-container.html, replace the contents with:
'''NOTE: the 1.0 version did not have a '-' before "listElements", but we need that hyphen there.'''
<pre><nowiki>
#{-listElements}
</nowiki></pre>

You will also need to create download-stream-popup.html in app/views/download:
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc="">This file type has been registered as a streaming media file. Would you like to download it to /media/internal/downloads instead?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Stream</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Download</div>
</div>
</nowiki></pre>

'''IMPORTANT NOTES:'''

The download widgets will be added to the bottom of the currently rendered page. If you are zoomed in, you probably won't be able to see them.

Swipe-to-delete works, but not the way you think. The widget will disappear, but the download will finish if it has not already, and will persist afterward. You will have to use a PC and mount the mass storage controller to remove downloads later.

'''SUCCESS''' - 6/23/2009
chris_phelps has completed a "Download" feature that creates it's own Scene for completed downloads in the browser.

[[Image:Dl-browser1.png]]
[[Image:Dl-browser2.png]]
[[Image:Dl-browser3.png]]

This however, was not the correct way to do things as the system is already keeping track of all downloads in it's own database. chris_phelps will be moving the code created specifically for the Download scene in the browser application into it's own application. Expect this by the end of the day maybe (6/24/2009) depending on how good the weather gets.

Patch Browser Downloading Files

2009-08-11T20:49:52Z

Dizzwave: added minor notes

{{template:patch}}

'''NOTE -- This is newly 1.1 compatible, but the Patch file linked below has not been updated. Anybody wanna do that for me?'''

'''ANOTHER NOTE -- I haven't extensively tested the 1.1 version of the changes. I've confirmed that it works for mp3s, but not other filetypes yet.'''

As of 2009/07/06, all parts of this modification have been incorporated into the patch file at http://gitorious.org/webos-internals/modifications/blobs/raw/master/browser/enable-browser-downloads.patch.

If further modifications are made, but for whatever reason the patch cannot be updated according to the steps at [[Applying Patches]], please place these changes above the "PATCH" line so that someone else can incorporate them into the patch (and then note that they have been incorporated)

'''NOTE''' from dizzwave -- sorry I didn't follow this rule, but since so much stuff got moved around, I didn't see the point of moving everything above the PATCH line. I hope that's ok.

This patch file contains all of the modifications described below the PATCH line, as well as a typo correction (believe it or not, mimeByExtenstion '''IS''' correct, see the following output if you don't believe it):

<pre><nowiki>
luna-send -n 1 palm://com.palm.applicationManager/getResourceInfo '{"uri":"http://www.podtrac.com/pts/redirect.mp3/aolradio.podcast.aol.com/twit/TWiT0202H.mp3"}'
</nowiki></pre>
'''NOTE''' They seem to have fixed that typo in 1.1. :)

Also included is a change to DownloadDialogAssistant that clears out the onDismiss function when streaming. Otherwise, anytime you selected stream, the file would be downloaded as well (in the cleanup function).

It would be good if the developers contributing code could get gitorious accounts and keep this patch updated ...A

= PATCH=

NOTE: 6/24/2009
chris_phelps merged all of the sections from mdklein back into one set of directions. If you have already done the first part, you will have to figure out what is left for yourself.

NOTE: 8/11/2009 (dizzwave) Making some minor changes to the code below so as to work with 1.1. My changes in '''bold''', with the old stuff <s>struckthrough</s>, for clarity (and to help whoever fixes up the patch file!:)).

During some of my initial digging in the Browser application, I discovered that Palm developers had left quite a bit of code in place to enable downloading via the web interface. User mdklein was interested in the same fix at the same time (6/22/2009), so we shared information as we moved forward.

'''CODE'''
The first step is to enable the required javascript sources through sources.json:

<pre><nowiki>
{
"source":"app\/models\/download-model.js"
},
{
"source":"app\/controllers\/download-request.js"
},
{
"source":"app\/controllers\/download-controller.js"
},
{
"source":"app\/controllers\/downloaddialog-assistant.js"
},
</nowiki></pre>

I put them directly before the import for <s>page-assistant.js</s>'''global_code.js''', as that is where they will be used from.

Next, at the end of the <s>app/controllers/page-assistant.js</s>'''global_code.js''' function "PageAssistant.prototype.setup" (right before the ''} catch(e){...)'':

<pre><nowiki>
this._downloadController = new DownloadController(this.controller);
this._downloadController.setup();
</nowiki></pre>

'''SUCCESS''' - 6/24/2009
mdklein has fixed the infinite loop bug with browsers and unknown filetypes. It's a simple modification. Please let me know if this breaks anything...

'''I (dizzwave) left this out for now, since that part of the browser code has changed since 1.0, and we might not need it. (Works for mp3s, anyway... might need to be refactored yet.)'''
<s>
in page-assistant.js change the if statement "&& response.mimeByExtenstion" is added to verify we know it's a mime type. (yes, Palm typoed)
writing it this way in case they fix the typo in the future.
<pre><nowiki>
// Yes, palm, I caught your typo... writing it this way in case you fix it? function returns mimeByExtenstion... guessing it should be mimeByExtension
if (response.returnValue && response.canStream && (response.mimeByExtenstion||response.mimeByExtension)) {
this._streamResource(event.url, response.appIdByExtension, (response.mimeByExtenstion||response.mimeByExtenstion));
}

</nowiki></pre>
</s>

And then the downloadResource function, '''also in global_code.cs''' (note that we are now presenting a confirmation dialog). Replace the current function with this:
<pre><nowiki>
PageAssistant.prototype._downloadResource = function(uri) {

Mojo.Log.info("Downloading: " + uri);

try {
// We should no longer download a resource but inform the user
// we are unable to perform the download.
if (!this._downloadWidgetElement) {
this._downloadWidgetElement = this.controller.showDialog({
template: 'download/download-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function() {
//this._onPopupHandler('close');
delete this._downloadWidgetElement;
}.bind(this),
onAccept: function() {
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this)})
});

// Record we have a popup
//this._onPopupHandler('open');
}
} catch (e) {
Mojo.Log.logException(e, "#_downloadResource");
}

// Hide the address bar.
this._addressBar.hide();
this._webView.mojo.focus();
};
</nowiki></pre>
'''NOTE I commented out the lines that called _onPopupHandler, since there seems to be no such handler now (that I could find), and it didn't seem to matter.'''

Now we change the PageAssistant.prototype._streamResource function ('''also in global_code.js''') to this:
<pre><nowiki>
PageAssistant.prototype._streamResource = function(uri, appid, mimeType){

Mojo.Log.error("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);

this._downloadWidgetElement = this.controller.showDialog({
uri: uri,
mimeType: mimeType,
appid: appid,
template: 'download/download-stream-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function(cParams) { // DOWNLOAD
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this),
onAccept: function(cParams) { // STREAM
var params = {target: uri, mimeType: mimeType, appid: appid};
// Only a few select applications can be
var crossAppScene = {
'com.palm.app.videoplayer': 'nowplaying',
'com.palm.app.streamingmusicplayer': 'nowplaying'
};
//this._onPopupHandler('close');
if (crossAppScene[appid]) {
var args = { appId: appid, name: crossAppScene[appid] };
this.controller.stageController.pushScene(args, params);
}
else {
this._downloadController.downloadResource(uri);
}
}.bind(this)})
});
// Record we have a popup
//this._onPopupHandler('open');

};
</nowiki></pre>
'''NOTE again that I commented out the _onPopupHandler calls.'''

Then we add a new file /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
<pre><nowiki>
/**
* A dialog assistant for display of yes/no box.
*/
DownloadDialogAssistant = Class.create({

initialize: function(params) {
this.onDismiss = params.onDismiss;
this.onAccept = params.onAccept;
this.controller= params.sceneAssistant.controller;

// Button handlers.
this.onDismissHandler = this.handleDismiss.bindAsEventListener(this);
this.onAcceptHandler = this.handleAccept.bindAsEventListener(this);
},

setup: function(widget) {
this.widget = widget;
this.controller.get('acceptButton').addEventListener(Mojo.Event.tap, this.onAcceptHandler);
this.controller.get('acceptButton').focus();
this.controller.get('dismissButton').addEventListener(Mojo.Event.tap, this.onDismissHandler);
this.controller.get('dismissButton').focus();
},

handleDismiss: function() {
this.onDismiss();
delete this.onDismiss;
this.widget.mojo.close();
},
handleAccept: function() {
this.onAccept();
delete this.onAccept;
this.widget.mojo.close();
},

cleanup: function() {
Mojo.Log.info("NetworkDialogAssistant#cleanup()");
Mojo.Event.stopListening(this.controller.get('dismissButton'), Mojo.Event.tap, this.onDismissHandler);
Mojo.Event.stopListening(this.controller.get('acceptButton'), Mojo.Event.tap, this.onAcceptHandler);

// Send a dismiss if NOT already sent a response
if (this.onDismiss) {
this.onDismiss();
}
}
});
</nowiki></pre>

'''RESOURCES'''
That is all the "code" that needs to be fixed. The rest would be considered resources.

you also need a /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc=""> Cannot find an application which can open this file. Would you like to download it to /media/internal/downloads?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Yes</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">No</div>
</div>
</nowiki></pre>

In app/views/page/page-scene.html, we append:

<pre><nowiki>
<div id="downloadListScroller" class="browser-download" x-mojo-element="Scroller">
<div id="downloadList" class="palm-list" x-mojo-element="List"></div>
</div>
</nowiki></pre>

and then in app/views/download/download-container.html, replace the contents with:
'''NOTE: the 1.0 version did not have a '-' before "listElements", but we need that hyphen there.'''
<pre><nowiki>
#{-listElements}
</nowiki></pre>

You will also need to create download-stream-popup.html in app/views/download:
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc="">This file type has been registered as a streaming media file. Would you like to download it to /media/internal/downloads instead?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Stream</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Download</div>
</div>
</nowiki></pre>

'''IMPORTANT NOTES:'''

The download widgets will be added to the bottom of the currently rendered page. If you are zoomed in, you probably won't be able to see them.

Swipe-to-delete works, but not the way you think. The widget will disappear, but the download will finish if it has not already, and will persist afterward. You will have to use a PC and mount the mass storage controller to remove downloads later.

'''SUCCESS''' - 6/23/2009
chris_phelps has completed a "Download" feature that creates it's own Scene for completed downloads in the browser.

[[Image:Dl-browser1.png]]
[[Image:Dl-browser2.png]]
[[Image:Dl-browser3.png]]

This however, was not the correct way to do things as the system is already keeping track of all downloads in it's own database. chris_phelps will be moving the code created specifically for the Download scene in the browser application into it's own application. Expect this by the end of the day maybe (6/24/2009) depending on how good the weather gets.

Portal:Patches to webOS

2009-08-11T20:42:47Z

Dizzwave: moved Patch Browser Download Files from "not 1.1 compatible" to "1.1 OK"

__notoc__
{{portal-header
|This page lists patches to webOS existing apps which modify the behavior as shipped. '''Note''' that these patches may be version specific and may be broken by future webOS updates. Proceed with caution. If you get one that works please move it under the correct column, alphabetically, and title the page:
'''"Patch [application] [description]"''' (for application specific patches) <br>
'''"Patch webOS [description]"''' (for patches not part of a specific application)
}}
This page is undergoing structuring please contribute moving or adding new entries under the appropriate headings. For now put pages in alphabetical order. Each page should contain at least the basic headings
*1. '''Introduction''': A brief description to introduce people to the patch.
**1.1 '''Usage''':An explanation if it is needed on how to use the modification see Add/Delete Pages in the Launcher as an example.
*2. '''Editing Process''': Step by step instructions to manually edit.
*3. '''Patching Process''': Details for making the edits with a patch file and pointing people to the [[Applying Patches]] page if the patch is also provided in the webos-internals gitorious repository.

{{portal-three-columns
|column1=
===webOS Update Information===
* [[Update 1.1.0|Update 1.1]]
* [[Update 1.0.4|Update 1.0.4]]
* [[Update 1.0.3|Update 1.0.3]]

===Patches that Need Work===
* [[Bugs]]

|column2=
===Patch Ideas to be Created or in Progress===

* [[Add_Ability_To_Choose_Snooze_Length|Add Ability to Choose Snooze Length]]
* [[Changing Clipboard Data From The Shell|Changing Clipboard Data from the Shell]]
* [[Development_%26_Tweak_Ideas | Development & Tweaking Ideas]]
* [[Longer Vibrate|Longer Vibrate]]
* [[More_Calculator_Functions|Accessing additional built-in calculator functions]]

|column3=
===Notes===
These modifications lack a patch process, please add one to the details to the page and have it added to the webOS-internals gitorious repository. Info for the repository is on [[Applying Patches]].

*Empty
}}
{{portal-three-columns
|column1=
==Patches to webOS apps==
===webOS 1.1 OK===

* [[Patch Amazon Download Music over EVDO|Amazon: Download Music over EVDO]]
* [[Patch Browser Global Search Addons|Browser: Global Search Addons]]
* [[Patch Browser Delete Individual History Items|Browser: Delete Individual History Items]]
* [[Patch Browser Downloading Files|Browser: Downloading Files]]
* [[Patch Calendar Show All-Day Events in Month View|Calendar: Show All-Day Events in Month View]]
* [[Patch Camera 10 Second Countdown Timer|Camera: 10 Second Countdown Timer]]
* [[Patch Camera Shutter Sound On-Off Button|Camera: Shutter Sound On-Off Button]]
* [[Patch Camera Using Volume Buttons to Take a Picture|Camera: Using Volume Buttons to Take a Picture]]
* [[Patch Clock Changing Alarm Button Order and Snooze Duration|Clock: Changing Alarm Button Order and Snooze Duration]]
* [[Patch Clock Enabling the Hidden Theme|Clock: Enabling the Hidden Theme]]
* [[Patch Email Change "Running Late" Message|Email: Change "Running Late" Message]]
* [[Patch Email Confirm Deletion|Email: Confirm Deletion]]
* [[Patch Email Change Default Font for Replies-Forwards from Navy to Black|Email: Change Default Font for Replies/Forwards from Navy to Black]]
* [[Patch Email DeleteAll|Email: Delete All]]
* [[Patch Launcher Add or Delete Pages|Launcher: Add/Delete Pages]]
* [[Patch Launcher To Allow More Icons Per Row|Launcher: Allows More Icons Per Row]]
* [[Patch Launcher Hide-Delete The NASCAR App|Launcher: Hide/Delete The NASCAR App]]
* [[Patch Launcher Hide Media Sync Option|Launcher: Hide Media Sync Option]]
* [[Patch Launcher Unhide the DeveloperMode App|Launcher: Unhide the DeveloperMode App]]
* [[Patch MediaPlayer Bookmarking|MediaPlayer: Bookmarking]]
* [[Patch Messaging Adding Timestamps to All Received Messages|Messaging: Adding Timestamps to All Received Messages]]
* [[Patch Messaging Change "Enter Key" To Create Newline|Messaging: Change "Enter Key" To Create Newline]]
* [[Patch Messaging Character Counter|Messaging: Character Counter]]
* [[Patch Messaging Display Full Status Messages|Messaging: Display Full Status Messages]]
* [[Patch Messaging Force Offline Send Without Dialog]]
* [[Patch Messaging Forward Messages|Messaging: Forward Messages]]
* [[Patch Messaging New Cards For Each Conversation|Messaging: New Cards For Each Conversation]]
* [[Patch Messaging Sounds|Messaging: Message Sound]]
* [[Patch MCraig Enabling Personals Category|mCraig: Enabling Personals Category]]
* [[Patch Music App Ignore 'A', 'An', and 'The' In Artist and Album names|Ignore 'A', 'An', and 'The' In Artist and Album names]]
* [[Patch PDF Viewer Change Orientation|PDF Viewer: Change Orientation]]
* [[Patch Phone Disable Various Call Sounds|Phone: Disable Various Call Sounds]]
* [[Patch Phone Edit Dialer Theme|Phone: Edit Dialer Theme]]
* [[Patch Phone Editing the Lock Screen|Phone: Editing the Lock Screen]]
* [[Patch Phone Show Call Duration in the Call Log|Phone: Show Call Duration in the Call Log]]
* [[Patch Tasks Always Show Details of New Tasks|Tasks: Always Show Details of New Tasks]]

===Fixed in 1.1 - No longer needed===
* [[Patch Email Fix Broken Formatting|Email: Fix Broken Formatting for E-mails]]

===Not 1.1 compatible===
* [[Patch Camera Remote View|Camera: Remote View]]
* [[Patch Email Enable Landscape Viewing|Email: Enable Landscape Viewing]]
* [[Patch Email Fix Attachments|Email: Fix Attachments]]

|column2=
==Patches not part of a specific app==
===webOS 1.1 OK===
* [[Patch webOS Boot Themes|Boot Themes]]
* [[Patch webOS Brightness|Brightness]]
* [[Patch webOS Bypassing Activation|Bypassing Activation]]
* [[Patch webOS Change Carrier String|Change Carrier String]]
* [[Change_the_default_notification.wav_Sound|Change the Default notification.wav Sound]]
* [[Patch webOS Changing the "Turn off after X" time|Changing the "Turn off after X" Time]]
* [[Patch webOS CPU Frequency or Voltage Scaling|CPU Frequency or Voltage Scaling]]
* [[Patch webOS Disable Charging Event Sounds|Disable Charging Event Sounds]]
* [[Patch webOS GPS Tracking|GPS Tracking]]
* [[Patch webOS Graphics|Graphics]]
* [[Patch webOS Hourly Chime|Hourly Chime]]
* [[Patch webOS Turning Off Dialpad Noise|Turning Off Dialpad Noise]]
* [[Patch webOS Keep Phone Awake While in Remote Session|Keep Phone Awake While in Remote Session]]
* [[Patch webOS Logging Information from Within Scripts|Logging Information from Within Scripts]]
* [[Patch webOS Modifying a Stock App While Keeping the Original|Modifying a Stock App While Keeping the Original]]
* [[Patch webOS Add Words to AutoCorrect Dictionary|Modify AutoCorrect Dictionary]]
* [[Patch webOS Radio Power Switch|Radio Power Switch]]
* [[Patch webOS Random Wallpaper Switching|Random Wallpaper Switching]]
* [[Patch webOS Reverse Tunnel|Reverse Tunnel]]
* [[Patch webOS Roam Control|Roam Control]]
* [[Patch webOS Show Actual Battery Percentage | Show Actual Battery Percentage]]
* [[Screenlock On When Connected|Stay On While Connected]]
* [[Make USB Partition Writable via SFTP|Make_USB_Partition_writable_via_SFTP]]

===Fixed in 1.1 - No longer needed===
* Empty

===Not 1.1 compatible===
* [[Patch webOS Email App Patch to Prompt for IPK Installation|Email App Patch to Prompt for IPK Installation]]

|column3=
==== The following have not been checked for compatibility with webOS 1.1. ====

* [[Browser_Plugins|Browser Plugins]]
* [[Camera Mod Alternate Sound Disable]]
* [[Changes_Alert/Notification_Sounds|Changes Alert/Notification Sounds]]
* [[My notification|My notification]]
* [[Myavatar In Messaging App|Myavatar In Messaging App]]
* [[Photos Slideshow|Photos Slideshow]]
* [[Patch Sudoku Disable Zooming|Sudoku: Disable Zooming]]

==== The following are deprecated. They have been replaced with methods which are easier or are moot in 1.1 ====

* [[Installing Homebrew Apps With A Rooted Pre|Installing Homebrew Apps With A Linux Accessed Pre]]
* [[Packaging Homebrew Apps for Stock Pre without Rooting|Packaging Homebrew Apps for Stock Pre without Accessing Linux]]
* [[Modifying Stock Applications|Modifying Stock Applications]]

}}

Patch Browser Downloading Files

2009-08-11T20:41:19Z

Dizzwave: refactored this patch for 1.1, and did some minor tidying up of the page.

{{template:patch}}
As of 2009/07/06, all parts of this modification have been incorporated into the patch file at http://gitorious.org/webos-internals/modifications/blobs/raw/master/browser/enable-browser-downloads.patch.

If further modifications are made, but for whatever reason the patch cannot be updated according to the steps at [[Applying Patches]], please place these changes above the "PATCH" line so that someone else can incorporate them into the patch (and then note that they have been incorporated)

This patch file contains all of the modifications described below the PATCH line, as well as a typo correction (believe it or not, mimeByExtenstion '''IS''' correct, see the following output if you don't believe it):

<pre><nowiki>
luna-send -n 1 palm://com.palm.applicationManager/getResourceInfo '{"uri":"http://www.podtrac.com/pts/redirect.mp3/aolradio.podcast.aol.com/twit/TWiT0202H.mp3"}'
</nowiki></pre>

Also included is a change to DownloadDialogAssistant that clears out the onDismiss function when streaming. Otherwise, anytime you selected stream, the file would be downloaded as well (in the cleanup function).

It would be good if the developers contributing code could get gitorious accounts and keep this patch updated ...A

NOTE: 7/25/2009 Doesn't seem to work with 1.1 update (?) Worked great for months, update, now doesn't. Other patches work ok after update.

REPLY: 7/29/2009 Indeed. I never even got around to using it until now. It's too bad.

REPLY 2: 7/30/2009 The reason this patch doesn't work is because Palm has revamped the browser code. They have basically moved it all into one file. This shouldn't be too hard to fix. I'll look into it later.

REPLY 3: 8/11/2009 (dizzwave) This now works with 1.1, and as you guessed, it wasn't too hard to fix. I haven't updated the patch file yet, anybody else want to do that?

= PATCH=

NOTE: 6/24/2009
chris_phelps merged all of the sections from mdklein back into one set of directions. If you have already done the first part, you will have to figure out what is left for yourself.

NOTE: 8/11/2009 (dizzwave) Making some minor changes to the code below so as to work with 1.1. My changes in '''bold''', with the old stuff <s>struckthrough</s>, for clarity (and to help whoever fixes up the patch file!:)).

During some of my initial digging in the Browser application, I discovered that Palm developers had left quite a bit of code in place to enable downloading via the web interface. User mdklein was interested in the same fix at the same time (6/22/2009), so we shared information as we moved forward.

'''CODE'''
The first step is to enable the required javascript sources through sources.json:

<pre><nowiki>
{
"source":"app\/models\/download-model.js"
},
{
"source":"app\/controllers\/download-request.js"
},
{
"source":"app\/controllers\/download-controller.js"
},
{
"source":"app\/controllers\/downloaddialog-assistant.js"
},
</nowiki></pre>

I put them directly before the import for <s>page-assistant.js</s>'''global_code.js''', as that is where they will be used from.

Next, at the end of the <s>app/controllers/page-assistant.js</s>'''global_code.js''' function "PageAssistant.prototype.setup" (right before the ''} catch(e){...)'':

<pre><nowiki>
this._downloadController = new DownloadController(this.controller);
this._downloadController.setup();
</nowiki></pre>

'''SUCCESS''' - 6/24/2009
mdklein has fixed the infinite loop bug with browsers and unknown filetypes. It's a simple modification. Please let me know if this breaks anything...

'''I (dizzwave) left this out for now, since that part of the browser code has changed since 1.0, and we might not need it. (Works for mp3s, anyway... might need to be refactored yet.)'''
<s>
in page-assistant.js change the if statement "&& response.mimeByExtenstion" is added to verify we know it's a mime type. (yes, Palm typoed)
writing it this way in case they fix the typo in the future.
<pre><nowiki>
// Yes, palm, I caught your typo... writing it this way in case you fix it? function returns mimeByExtenstion... guessing it should be mimeByExtension
if (response.returnValue && response.canStream && (response.mimeByExtenstion||response.mimeByExtension)) {
this._streamResource(event.url, response.appIdByExtension, (response.mimeByExtenstion||response.mimeByExtenstion));
}

</nowiki></pre>
</s>

And then the downloadResource function, '''also in global_code.cs''' (note that we are now presenting a confirmation dialog). Replace the current function with this:
<pre><nowiki>
PageAssistant.prototype._downloadResource = function(uri) {

Mojo.Log.info("Downloading: " + uri);

try {
// We should no longer download a resource but inform the user
// we are unable to perform the download.
if (!this._downloadWidgetElement) {
this._downloadWidgetElement = this.controller.showDialog({
template: 'download/download-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function() {
//this._onPopupHandler('close');
delete this._downloadWidgetElement;
}.bind(this),
onAccept: function() {
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this)})
});

// Record we have a popup
//this._onPopupHandler('open');
}
} catch (e) {
Mojo.Log.logException(e, "#_downloadResource");
}

// Hide the address bar.
this._addressBar.hide();
this._webView.mojo.focus();
};
</nowiki></pre>
'''NOTE I commented out the lines that called _onPopupHandler, since there seems to be no such handler now (that I could find), and it didn't seem to matter.'''

Now we change the PageAssistant.prototype._streamResource function ('''also in global_code.js''') to this:
<pre><nowiki>
PageAssistant.prototype._streamResource = function(uri, appid, mimeType){

Mojo.Log.error("Streaming: '%s' with '%s' (%s)", uri, appid, mimeType);

this._downloadWidgetElement = this.controller.showDialog({
uri: uri,
mimeType: mimeType,
appid: appid,
template: 'download/download-stream-popup',
assistant: new DownloadDialogAssistant({
sceneAssistant: this,
onDismiss: function(cParams) { // DOWNLOAD
//this._onPopupHandler('close');
this._downloadController.downloadResource(uri);
}.bind(this),
onAccept: function(cParams) { // STREAM
var params = {target: uri, mimeType: mimeType, appid: appid};
// Only a few select applications can be
var crossAppScene = {
'com.palm.app.videoplayer': 'nowplaying',
'com.palm.app.streamingmusicplayer': 'nowplaying'
};
//this._onPopupHandler('close');
if (crossAppScene[appid]) {
var args = { appId: appid, name: crossAppScene[appid] };
this.controller.stageController.pushScene(args, params);
}
else {
this._downloadController.downloadResource(uri);
}
}.bind(this)})
});
// Record we have a popup
//this._onPopupHandler('open');

};
</nowiki></pre>
'''NOTE again that I commented out the _onPopupHandler calls.'''

Then we add a new file /usr/palm/applications/com.palm.app.browser/app/controllers/downloaddialog-assistant.js
<pre><nowiki>
/**
* A dialog assistant for display of yes/no box.
*/
DownloadDialogAssistant = Class.create({

initialize: function(params) {
this.onDismiss = params.onDismiss;
this.onAccept = params.onAccept;
this.controller= params.sceneAssistant.controller;

// Button handlers.
this.onDismissHandler = this.handleDismiss.bindAsEventListener(this);
this.onAcceptHandler = this.handleAccept.bindAsEventListener(this);
},

setup: function(widget) {
this.widget = widget;
this.controller.get('acceptButton').addEventListener(Mojo.Event.tap, this.onAcceptHandler);
this.controller.get('acceptButton').focus();
this.controller.get('dismissButton').addEventListener(Mojo.Event.tap, this.onDismissHandler);
this.controller.get('dismissButton').focus();
},

handleDismiss: function() {
this.onDismiss();
delete this.onDismiss;
this.widget.mojo.close();
},
handleAccept: function() {
this.onAccept();
delete this.onAccept;
this.widget.mojo.close();
},

cleanup: function() {
Mojo.Log.info("NetworkDialogAssistant#cleanup()");
Mojo.Event.stopListening(this.controller.get('dismissButton'), Mojo.Event.tap, this.onDismissHandler);
Mojo.Event.stopListening(this.controller.get('acceptButton'), Mojo.Event.tap, this.onAcceptHandler);

// Send a dismiss if NOT already sent a response
if (this.onDismiss) {
this.onDismiss();
}
}
});
</nowiki></pre>

'''RESOURCES'''
That is all the "code" that needs to be fixed. The rest would be considered resources.

you also need a /usr/palm/applications/com.palm.app.browser/app/views/download/download-popup.html
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc=""> Cannot find an application which can open this file. Would you like to download it to /media/internal/downloads?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Yes</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">No</div>
</div>
</nowiki></pre>

In app/views/page/page-scene.html, we append:

<pre><nowiki>
<div id="downloadListScroller" class="browser-download" x-mojo-element="Scroller">
<div id="downloadList" class="palm-list" x-mojo-element="List"></div>
</div>
</nowiki></pre>

and then in app/views/download/download-container.html, replace the contents with:
'''NOTE: the 1.0 version did not have a '-' before "listElements", but we need that hyphen there.'''
<pre><nowiki>
#{-listElements}
</nowiki></pre>

You will also need to create download-stream-popup.html in app/views/download:
<pre><nowiki>
<div id="palm-dialog-content" class="palm-dialog-content">
<div class="dialog-message" x-mojo-loc="">This file type has been registered as a streaming media file. Would you like to download it to /media/internal/downloads instead?</div>
</div>

<div class="palm-dialog-buttons">
<div class="dismiss palm-button" id="acceptButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Stream</div>
<div class="dismiss palm-button" id="dismissButton" x-mojo-loc="" x-mojo-tap-highlight="momentary">Download</div>
</div>
</nowiki></pre>

'''IMPORTANT NOTES:'''

The download widgets will be added to the bottom of the currently rendered page. If you are zoomed in, you probably won't be able to see them.

Swipe-to-delete works, but not the way you think. The widget will disappear, but the download will finish if it has not already, and will persist afterward. You will have to use a PC and mount the mass storage controller to remove downloads later.

'''SUCCESS''' - 6/23/2009
chris_phelps has completed a "Download" feature that creates it's own Scene for completed downloads in the browser.

[[Image:Dl-browser1.png]]
[[Image:Dl-browser2.png]]
[[Image:Dl-browser3.png]]

This however, was not the correct way to do things as the system is already keeping track of all downloads in it's own database. chris_phelps will be moving the code created specifically for the Download scene in the browser application into it's own application. Expect this by the end of the day maybe (6/24/2009) depending on how good the weather gets.