WebOS Internals - User contributions [en]

Applying Patches

2009-10-25T07:35:16Z

Sivan:

==Introduction==

We cannot legally redistribute Palm source code (it is copyrighted code, and is not released under an open source license) therefore we need to manage our modifications as patches. Since these patches will come from many different places, and will need to be removed before each OTA update and then reapplied after-wards, we need a procedure and tools for doing this. This page documents this procedure.

Before asking questions about this procedure, please read the following documents fully:

An introduction to Quilt can be found at http://www.suse.de/~agruen/quilt.pdf

The manual for quilt is at http://linux.die.net/man/1/quilt

==Upgrading from quilt to quilt-lite==

If you have performed these instructions before the 8th Aug 2009, you will have installed a very heavyweight version of the quilt package which has a dependency on a very large perl package.

This dependency has been removed in a new quilt-lite package, which saves 26MB of space in /var as a result.

You can switch over to it as follows:

* ipkg-opt update
* ipkg-opt remove quilt perl libdb gdbm util-linux-ng e2fslibs ncursesw
* ipkg-opt install quilt-lite

Alternatively, the setup script below will prompt to uninstall quilt, perl, etc ..., and install quilt-lite, if quilt is installed.

==Setup Procedure (Scripted)==
The process of setting up quilt has been scripted. The script performs the following actions:
* Installs (or upgrades) git and any dependencies
* Installs (or upgrades) quilt (actually quilt-lite, a version of quilt that does not depend on perl) and any dependencies
* Configures quilt to store patches in /opt/src/patches
* Creates (or updates) a local clone of the webos-internals modifications repository

Each step is only performed if necessary. Please note that ipkg-opt needs to be installed. The instructions are found [[Next_steps|here]].

To get run the script, log into your Pre, gain root privileges and run the following commands:
<pre><nowiki>
cd /tmp
wget http://gitorious.org/webos-internals/bootstrap/blobs/raw/master/quilt-bootstrap.sh
sh quilt-bootstrap.sh
</nowiki></pre>

==Setup Procedure (Manual Process)==
(Note: Even though you may have previously installed the optware quilt patch manager, it won't damage anything to follow the Setup procedure. Alternatively, if you KNOW FOR SURE these are installed and your packages are up-to-date, you can skip to Importing and Applying Patches).

* Log into your Pre, and gain root privileges. (Note: This command is not required when using the emulator)
<pre><nowiki>
sudo -i # Yes, the -i is important.
</nowiki></pre>

* Put your Pre in to Read Write Mode
<pre><nowiki>
mount -o remount,rw /
</nowiki></pre>

* Ensure that you are set up for optware package installations, and make sure you have the latest package index:
<pre><nowiki>
ipkg-opt update
</nowiki></pre>

* Install the 'quilt-lite' package, which will be used to manage the patches you apply, and the 'git' package, which will be used to download existing patches from the modifications repository:
<pre><nowiki>
ipkg-opt install quilt-lite git
</nowiki></pre>

(If you already have those packages installed, repeating this step will not cause any harm.)

* Create a directory in which 'quilt' will manage your chosen modifications:
<pre><nowiki>
mkdir -p /opt/src/patches
</nowiki></pre>

* Edit /opt/etc/quilt.quiltrc to point quilt to that directory:
<pre><nowiki>
sed -ire 's|^[\s#]*QUILT_PATCHES=.*|QUILT_PATCHES=/opt/src/patches|' /opt/etc/quilt.quiltrc
</nowiki></pre>

* Delete any existing webos-internals modifications directories
<pre><nowiki>
rm -rf /opt/src/modifications
</nowiki></pre>

* Clone the webos-internals modifications repository:
<pre><nowiki>
cd /opt/src
git clone git://gitorious.org/webos-internals/modifications.git
</nowiki></pre>

==Importing and Applying Patches==

* Ensure your list of modifications is up to date
<pre><nowiki>
cd /opt/src/modifications
git pull
</nowiki></pre>
** If you find yourself getting errors when you try to pull with the above command then you will need to modify your .git/config file
<pre><nowiki>
sudo vi /opt/src/modifications/.git/config
</nowiki></pre>

** Your [master] section should look like the following
<pre><nowiki>
[branch "master"]
remote = origin
merge = refs/heads/master
</nowiki></pre>

* Browse the set of available patches. Each patch should have a description at the top.
<pre><nowiki>
find /opt/src/modifications -name *.patch
</nowiki></pre>

* Choose a patch from the modifications repository and import it into your own patches directory:
<pre><nowiki>
cd / # It is *very* important to be in the / directory when you run quilt.
quilt import /opt/src/modifications/application_name/patch_name.patch # Note that you need to replace application_name and patch_name here.
</nowiki></pre>

* Verify that quilt has imported the patch successfully:
<pre><nowiki>
# You should still be in the / directory to run quilt.
quilt series # you should see your patch listed in here
</nowiki></pre>

* Instruct quilt to apply your patch
<pre><nowiki>
# You should still be in the / directory to run quilt.
quilt push
# Use this to push all patches at once.
quilt push -a
</nowiki></pre>

* If everything worked correctly, the patch should now be applied. You will usually need to restart the luna service on the Pre to see the effect of patches to applications. Here's how to initiate a rescan.
<pre><nowiki>
luna-send -n 1 palm://com.palm.applicationManager/rescan {}
</nowiki></pre>

If that doesn't work, try a service restart with:
<pre><nowiki>
stop LunaSysMgr && start LunaSysMgr
</nowiki></pre>

And if all else fails, simply reboot:
<pre><nowiki>
reboot
</nowiki></pre>

==Listing Applied Patches==
<pre><nowiki>
cd / # It is *very* important to be in the / directory when you run quilt.
quilt applied
</nowiki></pre>

==Removing All Patches==

Before you accept an over-the-air (OTA) update, you should remove any patches you have applied. Luckily, using quilt makes this very easy.

* Remove all patches:
<pre><nowiki>
cd / # It is *very* important to be in the / directory when you run quilt.
quilt pop -a
</nowiki></pre>

==Reapplying all patches==

After your OTA update is complete, you will want to reapply any patches you have selected. This may or may not go smoothly.

* Apply all patches:
<pre><nowiki>
cd / # It is *very* important to be in the / directory when you run quilt.
quilt push -a
</nowiki></pre>

* Put your Pre back in to Read Only mode
<pre><nowiki>
mount -o remount,ro /
</nowiki></pre>

==Quilt Commands==

Other commands when using Quilt-Lite:

Please feel free to add/edit this section. I am not an expert, these are commands that I found by accident when i misspelled delete.

<pre><nowiki>
quilt
add
applied (shows applied/installed patches)
delete (removes a patch from quilt series ex: quilt delete *name of patch*)
diff
edit
files
fold
fork
graph
grep
header
import (downloads patch from git ex: quilt import *name of patch*)
mail
new
next
patches
pop
previous
push (installs patches from quilt series one at a time. quilt push -a installs all patches)
refresh
rename
revert
series (shows all downloaded patches.)
setup
snapshot
top
unapplied
upgrade

</nowiki></pre>

==Information for developing patches==

===Getting Authenticated with gitorious.org===
Before you can commit to gitorious you need to [http://gitorious.org/users/new create an account].

Next, you'll need to create a public/private key pair, and the easiest way to do this is with openssh. If you want to create a pair with windows, there are PuTTYgen/Pageant instructions below under "Alternate Windows Method", but the following may be easier. After you generate a public key you'll share it with gitorious.org; your public key is how gitorious.org authenticates you and checks if have the permissions required to do a commit to a given repository.
<pre><nowiki>
ipkg-opt update
ipkg-opt install openssh # *see Note Below
sudo ssh-keygen -t rsa # follow the prompts, ensure you're saving to /var/home/root/.ssh
cat /var/home/root/.ssh/id_rsa.pub # copy the output and paste it into gitorious key manager
</nowiki></pre>
<nowiki>*</nowiki>There's been some work to get dropbear working, but this tutorial assumes you have openssh installed. For information about dropbear and ssh keys, see [http://tumblelog.jauderho.com/post/151678345/using-dropbear-with-git this page]
* Don't forget to upload your public key from the last statement above to gitorious.org

Next, you'll need to ensure you have your environment properly configured.

<pre><nowiki>
echo $GIT_SSH # Should be /opt/bin/openssh-ssh
</nowiki></pre>

If the output of this command are anything other than /opt/bin/openssh-ssh, you'll need to update /etc/profile.d/optware. Add

<pre><nowiki>
export GIT_SSH=/opt/bin/openssh-ssh
</nowiki></pre>

To the top of the /etc/profile.d/optware.

Now you should be able to follow the steps below and contribute your code to gitorious.org.

'''Alternate Windows Method'''

The only reasons you might want to pursue this method is if you want to generate a ssh key pair on a Windows box.

Getting your key on window
* Download [http://www.chiark.greenend.org.uk/~sgtatham/putty/download.html PuTTYgen] and [http://www.chiark.greenend.org.uk/~sgtatham/putty/download.html Pageant]

--Gitorious.org [http://gitorious.org/about/faq gitorious.org recommends] you use [http://code.google.com/p/msysgit/ msysGit].--

* On Windows use [http://www.chiark.greenend.org.uk/~sgtatham/putty/download.html PuTTYgen] to generate a public/private key pair.

<pre><nowiki>
Key -> SSH-2 RSA KEY
Key -> Generate key pair
</nowiki></pre>
After some wiggling of the mouse your keys will be generated. You should fill in the //Key passphrase// and it's confirmation to secure you key. Save off the public and private key pairs to your user folder.

* After which you will need to run [http://www.chiark.greenend.org.uk/~sgtatham/putty/download.html Pageant] on your pc. Pageant holds your private key in memory for PuTTY to use.

===Creating a patch===

* Before making any changes to files:

<pre><nowiki>
cd / # It is *very* important to be in the / directory when you run quilt.
quilt new patch_name.patch
quilt add /usr/palm/applications/com.palm.app.appYouWantToMod/app/controllers/mod-assistant.js
quilt add /usr/palm/applications/com.palm.app.appYouWantToMod/app/controllers/mod2-assistant.js
</nowiki></pre>

* Now you can make changes on the Pre using vi/nano/joe/whatever, or sftp files to your machine and make changes. Make sure any file you change has been added in the above step.

<pre><nowiki>
quilt files # view files that are being tracked
quilt header -e # add a header to the patch to describe it (please do this!)
</nowiki></pre>

* Once you are finished and ready to create a patch

<pre><nowiki>
quilt refresh # this will create/update the /opt/src/patches/patch_name.patch file
</nowiki></pre>

===Pushing the change back to gitorious.org===

* copy the patch into the modification tree you cloned above

<pre><nowiki>
mkdir /opt/src/modifications/application_name # You need to change application_name to the leaf of the palm application id.
cp /opt/src/patches/patch_name.patch /opt/src/modifications/application_name/patch_name.patch
</nowiki></pre>

* Identify yourself in git (use the user you have setup at gitorious.org)

<pre><nowiki>
cd /opt/src/modifications
git config --global user.name "user"
git config --global user.email "youremail@example.com"
</nowiki></pre>

* Commit your changes to your local git

<pre><nowiki>
git add application_name/patch_name.patch
git commit
</nowiki></pre>

* Since we did a clone the first time, we need to recreate the origin:

<pre><nowiki>
git remote rm origin # (if you did a clone, we have to replace the origin)
git remote add origin git@gitorious.org:webos-internals/modifications.git
</nowiki></pre>
*This will destroy your ability to actually pull down updates, so you'll need to modify the /opt/src/modifications/.git/config to contain:

<pre><nowiki>
[branch "master"]
remote = origin
merge = refs/heads/master
</nowiki></pre>
* Finally, push your changes up to gitorious.org

<pre><nowiki>
git push origin master # first time
git push # any future pushes
</nowiki></pre>

* If the push does not work, try to debug the ssh connection
<pre><nowiki>
/opt/bin/ssh -v git@gitorious.org
</nowiki></pre>

==Extended, annotated sample session with quilt==
* First, we just need to setup a file to muck with
<pre><nowiki>
root@castle:/# cd /
root@castle:/# echo "Original file" > /usr/test
root@castle:/# echo "2nd lien" >> /usr/test
root@castle:/# echo "3rd ilne" >> /usr/test
root@castle:/# echo "last line" >> /usr/test
</nowiki></pre>
* Start a new patch (normally you'll want to use patch_name.patch, I just wanted a shortened name)
<pre><nowiki>
root@castle:/# quilt new p1
Patch /opt/src/patches/p1 is now on top
</nowiki></pre>
* You must quilt add any files that you are going to edit or create '''before''' you edit or create them.
<pre><nowiki>
root@castle:/# quilt add /usr/test
File /usr/test added to patch /opt/src/patches/p1
</nowiki></pre>
* Just using sed to correct the spelling on the 2nd line
<pre><nowiki>
root@castle:/# sed -i -e 's/lien/line/' /usr/test
</nowiki></pre>
* quilt refresh actually finds what you have changed and writes it to the patch file (at this point, you can use git to push your changes)
<pre><nowiki>
root@castle:/# quilt refresh
Refreshed patch /opt/src/patches/p1
</nowiki></pre>
* Just for fun, let's do it again
<pre><nowiki>
root@castle:/# quilt new p2
Patch /opt/src/patches/p2 is now on top
</nowiki></pre>
* Again, add file, make some changes, refresh to update the patch.
<pre><nowiki>
root@castle:/# quilt add /usr/test
File /usr/test added to patch /opt/src/patches/p2
root@castle:/# sed -i -e 's/ilne/line/' /usr/test
root@castle:/# quilt refresh
Refreshed patch /opt/src/patches/p2
</nowiki></pre>
* Just an example of rolling back changes
<pre><nowiki>
root@castle:/# quilt pop
Removing patch /opt/src/patches/p2
Restoring usr/test

Now at patch /opt/src/patches/p1
root@castle:/# quilt pop
Removing patch /opt/src/patches/p1
Restoring usr/test

Now at patch /opt/src/patches/enable-browser-downloads.patch
root@castle:/# cat /usr/test
Original file
2nd lien
3rd ilne
last line
</nowiki></pre>
* delete will delete the patch from your series, but leave the actual patch file in /opt/src/patches (so you could import it later)
<pre><nowiki>
root@castle:/# quilt delete p1
Removed patch /opt/src/patches/p1
</nowiki></pre>
* Since we removed p1, push will now apply p2. However, since p2 was applied against p1 originally, p2 will report an error. If the changes are too significant, you can force with -f, but you should carefully inspect the resulting files.
<pre><nowiki>
root@castle:/# quilt push
Applying patch /opt/src/patches/p2
patching file usr/test
Hunk #1 succeeded at 1 with fuzz 2.

Now at patch /opt/src/patches/p2
</nowiki></pre>
* If we want, we can refresh the patch so that future users of the patch do not receive the "fuzz" warning.
<pre><nowiki>
root@castle:/# quilt refresh
Refreshed patch /opt/src/patches/p2
root@castle:/# cat /usr/test
Original file
2nd lien
3rd line
last line
</nowiki></pre>
* cleanup
<pre><nowiki>
root@castle:/# rm /usr/test
</nowiki></pre>

==Background info==

* [http://pkg-perl.alioth.debian.org/howto/quilt.html quilt]

==Script for Updating/Installing Patches==

I just wanted to share the following script that I just finished testing out. It's only been tested on my Pre so far, as I don't have access to any others.. It just updates the patch list, prints out available patches, then lets you choose which to apply.

<pre><nowiki>
#!/opt/bin/bash

cd /opt/src/modifications
tput clear
echo Updating list...
git pull
tput clear
cd /

a=0
for inputline in $(find /opt/src/modifications -name *.patch | sort)
do
a=$(($a+1));
line="$(echo $inputline)"
MYARRAY[$a]="$line"
echo "${a}${line}" | awk -F "/" 'sub(".patch","",$6) {printf "%-3s %-15s %s\n", $1, $5, $6}'
done
echo "q quit"

x=$(($a+1));
until [ -n "$opt" ] ; do
read -p "Enter the line number for patch to apply [1 - $a] " opt
if [ "$opt" = "q" ] ; then
exit 0
fi
if [ "$opt" -lt "$x" 2> /dev/null ] && [ "$opt" -gt 0 2> /dev/null ] ; then
true
else
opt=""
fi
done

tput clear
cd /
quilt import ${MYARRAY[$opt]}
quilt push
luna-send -n 1 palm://com.palm.applicationManager/rescan {}

</nowiki></pre>

Talk:Patch MediaPlayer Bookmarking

2009-08-06T07:40:59Z

Sivan: New page: The bookmark at the end of a track chops off the last few seconds. I'll try looking into it.

The bookmark at the end of a track chops off the last few seconds. I'll try looking into it.

Patch Amazon Download Music over EVDO

2009-08-04T07:05:39Z

Sivan: /* Update: Fix for Pre 1.1.0 Amazon over EvDo. Patch available below */

{{template:patch}}
The Amazon app only allows downloading songs over WiFi. This will also allow downloading songs over EVDO/3G.

cd /usr/palm/applications/com.palm.app.amazonstore/app/models

cp download-manager.js download-manger.js.sav

'''
== Update: Fix for Pre 1.1.0 Amazon over EvDo. Patch available below ==
'''

To "comment out" a line, add // at the beginning. Example:
<pre><nowiki>
printf("This is code");
//printf("This is commented out");
</nowiki></pre>

edit download-manager.js

comment out lines 440-442

<pre><nowiki>
440: //if (userInitiated &&....
441: //this.showWifiRequired....
442: //}
</nowiki></pre>

then force lines 465 & 466 to be true and comment out line 467

<pre><nowiki>
465: if (1 == 1) {
466: if ( 1 == 1)
467: //|| PalmSystem.version.index....
</nowiki></pre>
reboot (or orange-sym-r)

Credit for 1.1.0 amazon over EvDo(3G) fix: Jack87

'''''Bellow only works prior to the 1.1.0 update'''''

<pre><nowiki>
Comment out lines 416-423 (if condition stating songs must be downloaded via wifi)
Force lines 446 and 447 to be always true.... if ( 1 == 1 )
446: if (1 == 1) {
447: if (1 == 1)
Comment out line 448 (test for "desktop")
Confirm you have appropriate matching parens and brackets

</nowiki></pre>

reboot (or orange-sym-r)

'''3. Patch is now available via Gitorious. Note that this is slightly different code but does the same:'''

[http://gitorious.org/webos-internals/modifications/blobs/98d872e197db5f4b36c2189224926a15ce70808d/amazonstore/amazon_evdo.patch Patch]

[http://www.webos-internals.org/wiki/Applying_Patches Applying Patches]

[http://forums.precentral.net/web-os-development/186493-modified-amazon-app-download-over-3g.html Discuss this mod on Pre Central]

[http://predev.wikidot.com/modify-stock-app-while-keeping-original See how to modify the app while keeping the original in Launcher]

It took about 30 seconds to download a 3 minute song over EVDO with speedtest showing about 1Mbps or so, but hard to say as speed was bursting up to 2Mbps and down to 1Mbps for each test.

[[Image:modify-stock-app.jpg]]
[[Image:modify-stock-app2.jpg]]

== Credit==
xorg, Jack87, patch submitted by sivan

Patch Amazon Download Music over EVDO

2009-08-04T07:04:07Z

Sivan: /* Credit */

{{template:patch}}
The Amazon app only allows downloading songs over WiFi. This will also allow downloading songs over EVDO/3G.

cd /usr/palm/applications/com.palm.app.amazonstore/app/models

cp download-manager.js download-manger.js.sav

'''
== Update: Fix for Pre 1.1.0 Amazon over EvDo. Patch available below ==
'''

To "comment out" a line, add // at the beginning. Example:
<pre><nowiki>
printf("This is code");
//printf("This is commented out");
</nowiki></pre>

edit download-manager.js

comment out lines 440-442

<pre><nowiki>
440: //if (userInitiated &&....
441: //this.showWifiRequired....
442: //}
</nowiki></pre>

then force lines 465 & 466 to be true and comment out line 467

<pre><nowiki>
465: if (1 == 1) {
466: if ( 1 == 1)
467: //|| PalmSystem.version.index....
</nowiki></pre>
reboot (or orange-sym-r)

Credit for 1.1.0 amazon over EvDo(3G) fix: Jack87

'''''Bellow only works prior to the 1.1.0 update'''''

<pre><nowiki>
Comment out lines 416-423 (if condition stating songs must be downloaded via wifi)
Force lines 446 and 447 to be always true.... if ( 1 == 1 )
446: if (1 == 1) {
447: if (1 == 1)
Comment out line 448 (test for "desktop")
Confirm you have appropriate matching parens and brackets

</nowiki></pre>

reboot (or orange-sym-r)

'''3. Patch is now available via Gitorious. Note that this is slightly different code but does the same:'''
[http://gitorious.org/webos-internals/modifications/blobs/98d872e197db5f4b36c2189224926a15ce70808d/amazonstore/amazon_evdo.patch Patch]
Applying patches: [http://www.webos-internals.org/wiki/Applying_Patches Applying Patches]

[http://forums.precentral.net/web-os-development/186493-modified-amazon-app-download-over-3g.html Discuss this mod on Pre Central]

[http://predev.wikidot.com/modify-stock-app-while-keeping-original See how to modify the app while keeping the original in Launcher]

It took about 30 seconds to download a 3 minute song over EVDO with speedtest showing about 1Mbps or so, but hard to say as speed was bursting up to 2Mbps and down to 1Mbps for each test.

[[Image:modify-stock-app.jpg]]
[[Image:modify-stock-app2.jpg]]

== Credit==
xorg, Jack87, patch submitted by sivan

Patch Amazon Download Music over EVDO

2009-08-04T04:51:27Z

Sivan: /* Update: Fix for Pre 1.1.0 Amazon over EvDo */

{{template:patch}}
The Amazon app only allows downloading songs over WiFi. This will also allow downloading songs over EVDO/3G.

cd /usr/palm/applications/com.palm.app.amazonstore/app/models

cp download-manager.js download-manger.js.sav

'''
== Update: Fix for Pre 1.1.0 Amazon over EvDo. Patch available below ==
'''

To "comment out" a line, add // at the beginning. Example:
<pre><nowiki>
printf("This is code");
//printf("This is commented out");
</nowiki></pre>

edit download-manager.js

comment out lines 440-442

<pre><nowiki>
440: //if (userInitiated &&....
441: //this.showWifiRequired....
442: //}
</nowiki></pre>

then force lines 465 & 466 to be true and comment out line 467

<pre><nowiki>
465: if (1 == 1) {
466: if ( 1 == 1)
467: //|| PalmSystem.version.index....
</nowiki></pre>
reboot (or orange-sym-r)

Credit for 1.1.0 amazon over EvDo(3G) fix: Jack87

'''''Bellow only works prior to the 1.1.0 update'''''

<pre><nowiki>
Comment out lines 416-423 (if condition stating songs must be downloaded via wifi)
Force lines 446 and 447 to be always true.... if ( 1 == 1 )
446: if (1 == 1) {
447: if (1 == 1)
Comment out line 448 (test for "desktop")
Confirm you have appropriate matching parens and brackets

</nowiki></pre>

reboot (or orange-sym-r)

'''3. Patch is now available via Gitorious. Note that this is slightly different code but does the same:'''
[http://gitorious.org/webos-internals/modifications/blobs/98d872e197db5f4b36c2189224926a15ce70808d/amazonstore/amazon_evdo.patch Patch]
Applying patches: [http://www.webos-internals.org/wiki/Applying_Patches Applying Patches]

[http://forums.precentral.net/web-os-development/186493-modified-amazon-app-download-over-3g.html Discuss this mod on Pre Central]

[http://predev.wikidot.com/modify-stock-app-while-keeping-original See how to modify the app while keeping the original in Launcher]

It took about 30 seconds to download a 3 minute song over EVDO with speedtest showing about 1Mbps or so, but hard to say as speed was bursting up to 2Mbps and down to 1Mbps for each test.

[[Image:modify-stock-app.jpg]]
[[Image:modify-stock-app2.jpg]]

== Credit==
xorg, Jack87, quilt patch by sivan

Patch Amazon Download Music over EVDO

2009-08-04T04:50:25Z

Sivan: /* Credit */

{{template:patch}}
The Amazon app only allows downloading songs over WiFi. This will also allow downloading songs over EVDO/3G.

cd /usr/palm/applications/com.palm.app.amazonstore/app/models

cp download-manager.js download-manger.js.sav

'''
== Update: Fix for Pre 1.1.0 Amazon over EvDo ==
'''

To "comment out" a line, add // at the beginning. Example:
<pre><nowiki>
printf("This is code");
//printf("This is commented out");
</nowiki></pre>

edit download-manager.js

comment out lines 440-442

<pre><nowiki>
440: //if (userInitiated &&....
441: //this.showWifiRequired....
442: //}
</nowiki></pre>

then force lines 465 & 466 to be true and comment out line 467

<pre><nowiki>
465: if (1 == 1) {
466: if ( 1 == 1)
467: //|| PalmSystem.version.index....
</nowiki></pre>
reboot (or orange-sym-r)

Credit for 1.1.0 amazon over EvDo(3G) fix: Jack87

'''''Bellow only works prior to the 1.1.0 update'''''

<pre><nowiki>
Comment out lines 416-423 (if condition stating songs must be downloaded via wifi)
Force lines 446 and 447 to be always true.... if ( 1 == 1 )
446: if (1 == 1) {
447: if (1 == 1)
Comment out line 448 (test for "desktop")
Confirm you have appropriate matching parens and brackets

</nowiki></pre>

reboot (or orange-sym-r)

'''3. Patch is now available via Gitorious. Note that this is slightly different code but does the same:'''
[http://gitorious.org/webos-internals/modifications/blobs/98d872e197db5f4b36c2189224926a15ce70808d/amazonstore/amazon_evdo.patch Patch]
Applying patches: [http://www.webos-internals.org/wiki/Applying_Patches Applying Patches]

[http://forums.precentral.net/web-os-development/186493-modified-amazon-app-download-over-3g.html Discuss this mod on Pre Central]

[http://predev.wikidot.com/modify-stock-app-while-keeping-original See how to modify the app while keeping the original in Launcher]

It took about 30 seconds to download a 3 minute song over EVDO with speedtest showing about 1Mbps or so, but hard to say as speed was bursting up to 2Mbps and down to 1Mbps for each test.

[[Image:modify-stock-app.jpg]]
[[Image:modify-stock-app2.jpg]]

== Credit==
xorg, Jack87, quilt patch by sivan

Patch Amazon Download Music over EVDO

2009-08-04T04:49:10Z

Sivan: /* Update: Added patch to Gitorious */

{{template:patch}}
The Amazon app only allows downloading songs over WiFi. This will also allow downloading songs over EVDO/3G.

cd /usr/palm/applications/com.palm.app.amazonstore/app/models

cp download-manager.js download-manger.js.sav

'''
== Update: Fix for Pre 1.1.0 Amazon over EvDo ==
'''

To "comment out" a line, add // at the beginning. Example:
<pre><nowiki>
printf("This is code");
//printf("This is commented out");
</nowiki></pre>

edit download-manager.js

comment out lines 440-442

<pre><nowiki>
440: //if (userInitiated &&....
441: //this.showWifiRequired....
442: //}
</nowiki></pre>

then force lines 465 & 466 to be true and comment out line 467

<pre><nowiki>
465: if (1 == 1) {
466: if ( 1 == 1)
467: //|| PalmSystem.version.index....
</nowiki></pre>
reboot (or orange-sym-r)

Credit for 1.1.0 amazon over EvDo(3G) fix: Jack87

'''''Bellow only works prior to the 1.1.0 update'''''

<pre><nowiki>
Comment out lines 416-423 (if condition stating songs must be downloaded via wifi)
Force lines 446 and 447 to be always true.... if ( 1 == 1 )
446: if (1 == 1) {
447: if (1 == 1)
Comment out line 448 (test for "desktop")
Confirm you have appropriate matching parens and brackets

</nowiki></pre>

reboot (or orange-sym-r)

'''3. Patch is now available via Gitorious. Note that this is slightly different code but does the same:'''
[http://gitorious.org/webos-internals/modifications/blobs/98d872e197db5f4b36c2189224926a15ce70808d/amazonstore/amazon_evdo.patch Patch]
Applying patches: [http://www.webos-internals.org/wiki/Applying_Patches Applying Patches]

[http://forums.precentral.net/web-os-development/186493-modified-amazon-app-download-over-3g.html Discuss this mod on Pre Central]

[http://predev.wikidot.com/modify-stock-app-while-keeping-original See how to modify the app while keeping the original in Launcher]

It took about 30 seconds to download a 3 minute song over EVDO with speedtest showing about 1Mbps or so, but hard to say as speed was bursting up to 2Mbps and down to 1Mbps for each test.

[[Image:modify-stock-app.jpg]]
[[Image:modify-stock-app2.jpg]]

== Credit==
xorg, Jack87