Difference between revisions of "Messaging Mods"

From WebOS Internals
Jump to navigation Jump to search
Line 3: Line 3:
 
[[Adding Timestamps to All Received Messages]]
 
[[Adding Timestamps to All Received Messages]]
  
= Add Timestamps to All Messages - another approach =
 
  
== Introduction ==
 
 
The method described above is the easiest way to display message timestamps.  I went a little farther since I didn't want the "Message Sent:" label and I also wanted to format the string a bit more.  While I was at it, I also modified the view for the message text to display as pre-formatted text since text messages are text after all, not html.
 
 
== Procedure ==
 
 
* same as steps 1 & 2 above
 
* save a backup of /usr/palm/applications/com.palm.app.messaging/
 
** stylesheets/messaging.css
 
** app/views/chatview/message/message-text.html
 
** app/controllers/chatview-assistant.js
 
* edit stylesheets/messaging.css
 
** search for the string 'messageText' and append the following after its style definition
 
 
.messageText pre {
 
    font-family: inherit;
 
    font-size: inherit;
 
    color: inherit;
 
}
 
.timeStamp {
 
    font-size: 12px;
 
    font-style: italic;
 
    color: #1111ff;
 
}
 
 
**feel free to change the style to your liking.  I tried using 'white-space: pre-wrap' in the .messageText class but it didn't behave as expected, hence the use of the pre tag.
 
* edit app/views/chatview/message/message-text.html
 
** change the single line to:
 
<nowiki><div class="messageText"><pre>#{-messageText}</pre> #{-errorContent}<span class="timeStamp">#{-timeStampText}</span</div></nowiki>
 
* edit app/controllers/chatview-assistant.js
 
** search for the string 'preFormatChatList:' and just below that look for 'var msg = stuff.list[i];'
 
** somewhere after that line (within the for loop) add the following:
 
var ts = new Date();
 
ts.setTime(msg.deviceTimeStamp);
 
msg.timeStampText = Mojo.Format.formatDate(ts,'short');
 
** note that I used msg.deviceTimeStamp which I believe is when your phone sent/received the message.  If you'd prefer the time it was actually sent by the sender, use msg.timeStamp instead.  while you're in here, you may consider applying the [[Change_Enter_To_Create_Newline_Instead_of_Send_Message|send on return behavior]] changes.
 
* restart LunaSysMgr or reboot
 
 
be sure to save the files you modified as they could get overwritten on the next sprint update.  better yet, install [[Applying_Patches|quilt]] to manage the diffs as a patch.
 
 
----
 
  
 
= New Card For Each Conversation =
 
= New Card For Each Conversation =

Revision as of 19:49, 29 July 2009

All files are located in /usr/palm/applications/com.palm.app.messaging/

Adding Timestamps to All Received Messages


New Card For Each Conversation

Introduction

The message app can be a pain when you have multiple conversations going on. You often have to swipe back and then pick someone else. It gets annoying fast. This modification modifies the messaging application so that a new card is created whenever you click into a conversation.

Procedure

Edit /usr/palm/applications/com.palm.app.messaging/app/controllers/listview-assistant.js and replace the launchChatView function with the following function:

launchChatView: function(chatThreadId) {
    //Need to jump to that stage if it exists
    var stageController = Mojo.Controller.appController.getStageController("messaging"+chatThreadId);
        if (stageController) {
            stageController.activate();
            return;
        }

    var params = {name: 'messaging' + chatThreadId,
            lightweight: Mojo.Controller.appInfo.lwStages
    };

    var callback = function(controller) {
        controller.pushScene('chatview',chatThreadId,{
                    focusWindow: true
                });        
    };

    Mojo.Controller.getAppController().createStageWithCallback(params, callback); //doesnt create ifit exists sooo
  },

  clearListBadgeForChatThreadId: function(chatThreadId) {
    var badgeContainers = ["buddyBageContainer","historyBageContainer"];
    var listItem;
    for (var i = 0; i < badgeContainers.length; i++) {
        listItem = this.controller.get(badgeContainers[i] + chatThreadId);
        if (listItem && !listItem.hasClassName('hide-unread-count')) {
            listItem.addClassName('hide-unread-count');
        }
    }    
  },

Now in /usr/palm/applications/com.palm.app.messaging/app/controllers/chatview-assistant.js, comment out lines 246 and 247 (webOS 1.1: comment out lines 289 and 290). This change will ensure that if you use the "back gesture" in a chat, the application doesn't bring you back to the conversation list...or do anything else.

To "comment out" a line, add // at the beginning. Example:

printf("This is code");
//printf("This is commented out");

Concerns

There is some delay in creating the new cards. I'm not sure why though. As stated above, the cards are only opened when you click into the conversation. Responding to a notification will result in the reuse of the buddy list window, and you have disabled the back gesture.

Acknolwedgements

Thanks to mikedg for the mod.

chris_phelps is continuing to work on this modification to get it working more completely. The first step is to clean up the other launchChatNNN functionality in app-assistant.js which accepts Luna System calls from the notification dashboard items which are created when a new message is received on the phone. These code modifications are being tested currently, and will be posted when we figure out how to clear the new message counters in the main listview-assistant.js.


Character Counter

Character Counter

Introduction

One of the features I liked about my old Treo was the character counter built-in to the messaging application. I thought it would be useful on the Pre, so I modified the messaging application to show the current character count. I made this a separate page from the other modifications because it requires many code changes. Maybe the other messaging modifications could be rolled into this page as well.

Procedure

Run the following commands:

In this example, I have the patch file located in my home directory under patches <source lang="bash"> cd / sudo patch -p0 --backup-if-mismatch < ~/patches/charcounter.patch </source>

This is what you should see if it ran properly: <source lang="text"> patching file /usr/palm/applications/com.palm.app.messaging/app/controllers/chatview-assistant.js patching file /usr/palm/applications/com.palm.app.messaging/app/controllers/compose-assistant.js patching file /usr/palm/applications/com.palm.app.messaging/app/utilities/CharacterCounter.js patching file /usr/palm/applications/com.palm.app.messaging/app/views/chatview/chatview-scene.html patching file /usr/palm/applications/com.palm.app.messaging/app/views/compose/compose-scene.html patching file /usr/palm/applications/com.palm.app.messaging/stylesheets/messaging.css </source>

These modifications will require LunaSysMgr to be restarted. A rescan will not work. After you've run the commands above, run one more command: <source lang="bash"> pkill LunaSysMgr </source>

charcounter.patch

<source lang="diff"> diff -ur /usr/palm/applications/com.palm.app.messaging/app/controllers/chatview-assistant.js /usr/palm/app-modified/com.palm.app.messaging/app/controllers/chatview-assistant.js --- /usr/palm/applications/com.palm.app.messaging/app/controllers/chatview-assistant.js 2009-07-18 00:22:14.000000000 -0500 +++ /usr/palm/app-modified/com.palm.app.messaging/app/controllers/chatview-assistant.js 2009-07-23 23:13:19.000000000 -0500 @@ -160,6 +160,11 @@

				segmentCountContainer: this.controller.get('segmentCounterContainer'),
				segmentCountElement: this.controller.get('segmentCounter'),
				setTextFieldValueFn: this.setTextFieldValue.bind(this)

+ }, + charCounter: { + charCountContainer: this.controller.get('charCounterContainer'), + charCountElement: this.controller.get('charCounter'), + setTextFieldValueFn: this.setTextFieldValue.bind(this)

			}
		};

diff -ur /usr/palm/applications/com.palm.app.messaging/app/controllers/compose-assistant.js /usr/palm/app-modified/com.palm.app.messaging/app/controllers/compose-assistant.js --- /usr/palm/applications/com.palm.app.messaging/app/controllers/compose-assistant.js 2009-07-18 00:22:14.000000000 -0500 +++ /usr/palm/app-modified/com.palm.app.messaging/app/controllers/compose-assistant.js 2009-07-23 23:14:11.000000000 -0500 @@ -140,6 +140,11 @@

			segmentCountContainer: this.controller.get('segmentCounterContainer'),
			segmentCountElement: this.controller.get('segmentCounter'),
			setTextFieldValueFn: this.setTextFieldValue.bind(this)

+ }, + charCounter: { + charCountContainer: this.controller.get('charCounterContainer'), + charCountElement: this.controller.get('charCounter'), + setTextFieldValueFn: this.setTextFieldValue.bind(this)

		}
	};

diff -ur /usr/palm/applications/com.palm.app.messaging/app/utilities/CharacterCounter.js /usr/palm/app-modified/com.palm.app.messaging/app/utilities/CharacterCounter.js --- /usr/palm/applications/com.palm.app.messaging/app/utilities/CharacterCounter.js 2009-07-18 00:22:14.000000000 -0500 +++ /usr/palm/app-modified/com.palm.app.messaging/app/utilities/CharacterCounter.js 2009-07-23 23:47:32.000000000 -0500 @@ -39,6 +39,10 @@

				containerElement: null,
				valueElement: null
			};

+ var charCounterUI = { + containerElement: null, + valueElement: null + };


			// TODO: eventually we might want to implement some cleverness that counts

@@ -185,6 +189,20 @@

				}
			};
			

+ var setCurrentCharCount = function(newCharCount) { + if(charCounterUI.valueElement) + charCounterUI.valueElement.update(newCharCount); + if(charCounterUI.containerElement) { + if (newCharCount == 0) { + if (charCounterUI.containerElement.visible()) + charCounterUI.containerElement.hide(); + } else { + if (!charCounterUI.containerElement.visible()) + charCounterUI.containerElement.show(); + } + } + }; +

			return {
				
				init: function(controller,platform,textElement,params) {

@@ -265,7 +283,13 @@

								setTextFieldValueFn = params.segmentCounter.setTextFieldValueFn;
							}						
						}

- + if(params.charCounter) { + charCounterUI.containerElement = params.charCounter.charCountContainer; + charCounterUI.valueElement = params.charCounter.charCountElement; + if(params.charCounter.setTextFieldValueFn) { + setTextFieldValueFn = params.charCounter.setTextFieldValueFn; + } + }

					}					
				},
				

@@ -304,6 +328,7 @@

					var rawCharacterData = getRawCharacterData();
					var messageData = parseMessage(rawCharacterData.message,rawCharacterData.count,_maxLength,true);
					adjustedCharacterCount = messageData.adjustedCharacterCount;

+ setCurrentCharCount(rawCharacterData.count);

					if (_maxLength > 0)
						setOverLimit(messageData.isOverLimit);
					setCurrentSegmentCount(messageData.segmentCount);				

diff -ur /usr/palm/applications/com.palm.app.messaging/app/views/chatview/chatview-scene.html /usr/palm/app-modified/com.palm.app.messaging/app/views/chatview/chatview-scene.html --- /usr/palm/applications/com.palm.app.messaging/app/views/chatview/chatview-scene.html 2009-07-18 00:22:14.000000000 -0500 +++ /usr/palm/app-modified/com.palm.app.messaging/app/views/chatview/chatview-scene.html 2009-07-23 23:16:55.000000000 -0500 @@ -22,6 +22,10 @@

+
+
+
+